pkg/cover: parallelize symbolizeModule to speed up the symbolize

google · May 13, 2024 · dce836e · dce836e
1 parent 748b2e8
commit dce836e
Showing 1 changed file with 22 additions and 4 deletions.
diff --git a/pkg/cover/backend/dwarf.go b/pkg/cover/backend/dwarf.go
@@ -473,12 +473,30 @@ func symbolizeModule(target *targets.Target, interner *symbolizer.Interner, objD
 func symbolize(target *targets.Target, interner *symbolizer.Interner, objDir, srcDir, buildDir string,
 	splitBuildDelimiters []string, pcs map[*Module][]uint64) ([]Frame, error) {
 	var frames []Frame
+	type frameResult struct {
+		frames []Frame
+		err    error
+	}
+	frameC := make(chan frameResult, len(pcs))
 	for mod, pcs1 := range pcs {
-		frames1, err := symbolizeModule(target, interner, objDir, srcDir, buildDir, splitBuildDelimiters, mod, pcs1)
-		if err != nil {
-			return nil, err
+		go func(mod *Module, pcs []uint64) {
+			res := frameResult{}
+			frames, err := symbolizeModule(target, interner, objDir, srcDir, buildDir, splitBuildDelimiters, mod, pcs)
+			if err != nil {
+				res.err = err
+				frameC <- res
+				return
+			}
+			res.frames = frames
+			frameC <- res
+		}(mod, pcs1)
+	}
+	for range pcs {
+		res := <-frameC
+		if res.err != nil {
+			return nil, res.err
 		}
-		frames = append(frames, frames1...)
+		frames = append(frames, res.frames...)
 	}
 	return frames, nil
 }