Fix null safety code generation and migrate to null safety #222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR strives to achieve the following:
pageloader
usable with Dart SDK 2.14+ and AngularDart 7+$WhateverPo
class is not generated at all. To see this, rerunbuild_runner build
and choose "Delete conflicting files".A few notes:
lib/src/generators
was because the moment one changes the language version, the builder gets angry. The correct way to do this is to create a dummy project, copy the files undergenerators
andapi
(the only thinggenerators
depend on) over, bump the dependencies in the dummy project, and do the migration there.DartType.displayName
vsDartType.getDisplayString(withNullability: bool)
. All of these are marked withTODO(null-safety)
.