Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kcodecs: fix build #12662

Merged
merged 1 commit into from
Oct 30, 2024
Merged

kcodecs: fix build #12662

merged 1 commit into from
Oct 30, 2024

Conversation

tyler92
Copy link
Contributor

@tyler92 tyler92 commented Oct 28, 2024

Changes:

  1. -DBUILD_TESTING=OFF for extra-cmake-modules and kcodecs
  2. -qt-zlib for qtbase

Copy link

tyler92 is a new contributor to projects/kcodecs. The PR must be approved by known contributors before it can be merged. The past contributors are: tsdgeos, maflcko, DonggeLiu, devtty1er, Dor1s

@vitorguidi
Copy link
Contributor

tyler92 is a new contributor to projects/kcodecs. The PR must be approved by known contributors before it can be merged. The past contributors are: tsdgeos, maflcko, DonggeLiu, devtty1er, Dor1s

@tsdgeos @maflcko @devtty1er does this look good to you?

@tsdgeos
Copy link
Contributor

tsdgeos commented Oct 29, 2024

Is the build failing? I don't remember getting an email about it

@tyler92
Copy link
Contributor Author

tyler92 commented Oct 29, 2024

@tsdgeos
Copy link
Contributor

tsdgeos commented Oct 29, 2024

The code is fine, please someone merge it.

I am sad that I am no longer receiving emails for failures :/

Copy link
Contributor

@vitorguidi vitorguidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vitorguidi vitorguidi merged commit f12a352 into google:master Oct 30, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants