[elfutils] fix build failure #12465
Merged
[elfutils] fix build failure #12465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
evverx has previously contributed to projects/elfutils. The previous PR was #9745 |
|
It seems elfutils has been failing to compile on OSS-Fuzz for a couple of weeks but looks like it has never been reported by OSS-Fuzz. I've just checked and I don't seem to have received any notifications either. The only place where the status is shown is https://oss-fuzz-build-logs.storage.googleapis.com/index.html#elfutils. |
evverx
changed the title
It fixes a bug where -Wno-error was passed along with CXX, which in turn led to `-Wno-error $CXX` being run instead of just `$CXX`. elfutils still fails to compile when libarchive is present but it doesn't affect OSS-Fuzz builds: https://sourceware.org/bugzilla/show_bug.cgi?id=32155. (It regressed in https://sourceware.org/git/?p=elfutils.git;a=commit;h=b9fd1dda0ba6ddf7dd14ff6745ea3e884a2f553a)
evverx
force-pushed
the
elfutils-build-failure
branch
from
9defbaf
to
b91f89e
Compare
shahsb
approved these changes
Sep 10, 2024
DavidKorczynski
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes a bug where -Wno-error was passed along with CXX, which in turn led to
-Wno-error $CXXbeing run instead of just$CXX.elfutils still fails to compile when libarchive is present but it doesn't
affect OSS-Fuzz builds: https://sourceware.org/bugzilla/show_bug.cgi?id=32155.
(It regressed in
https://sourceware.org/git/?p=elfutils.git;a=commit;h=b9fd1dda0ba6ddf7dd14ff6745ea3e884a2f553a)
Fixes https://oss-fuzz-build-logs.storage.googleapis.com/log-dbd59f4a-34f9-417e-ad2f-55ddd4995c79.txt
It's a follow-up to https://sourceware.org/git/?p=elfutils.git;a=commit;h=d6443d1a4df6057f9012d105037f52daaca911f1