Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc timeouts and ooms and allow these options in GH Action #12003

Merged

Conversation

ligurio
Copy link
Contributor

@ligurio ligurio commented May 27, 2024

report-timeouts:
description: "Whether to report fails due to timeout."
required: false
default: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these should default to true.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks.

@ligurio ligurio force-pushed the ligurio/fix-doc-timeouts-and-ooms branch from 7f117d9 to 4ebe23f Compare June 5, 2024 09:44
Copy link
Contributor

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ligurio
Copy link
Contributor Author

ligurio commented Jun 7, 2024

@jonathanmetzman who can merge it?

@jonathanmetzman jonathanmetzman merged commit a7c524d into google:master Jun 7, 2024
18 of 19 checks passed
@ligurio ligurio deleted the ligurio/fix-doc-timeouts-and-ooms branch June 7, 2024 20:04
ligurio added a commit to ligurio/oss-fuzz that referenced this pull request Jun 11, 2024
With disabled option `report-oom` in GH Action Github reports
a warning:

"Unexpected input(s) 'report_ooms', valid inputs are ['entryPoint',
'args', 'language', 'fuzz-seconds', 'dry-run', 'sanitizer', 'mode',
'github-token', 'storage-repo', 'storage-repo-branch',
'storage-repo-branch-coverage', 'report-unreproducible-crashes',
'minimize-crashes', 'parallel-fuzzing', 'output-sarif']".

The patch follows up commit a7c524d ("Fix doc timeouts and
ooms and allow these options in GH Action (google#12003)").
jonathanmetzman pushed a commit that referenced this pull request Jun 14, 2024
With disabled option `report-oom` in GH Action Github reports a warning:

"Unexpected input(s) 'report_ooms', valid inputs are ['entryPoint',
'args', 'language', 'fuzz-seconds', 'dry-run', 'sanitizer', 'mode',
'github-token', 'storage-repo', 'storage-repo-branch',
'storage-repo-branch-coverage', 'report-unreproducible-crashes',
'minimize-crashes', 'parallel-fuzzing', 'output-sarif']".

The patch follows up commit a7c524d ("Fix doc timeouts and ooms and
allow these options in GH Action (#12003)").
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants