Temporary build workaround no longer required

[jreiser]

The upx project itself already applied such a change in order to make its own CI work properly. Also, a newer version of the default compilers obviated the change anyway.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[github-actions]

jreiser is a new contributor to projects/upx. The PR must be approved by known contributors before it can be merged. The past contributors are: MykolaMykhno

[jreiser]

I cannot tell whether my additional email address [email protected] has passed the CLA check.
I intend that to be the case, and I entered my alternate address on the CLA that I signed.
(Note that my "alternate" email address is the one that I have used for contributions to the underlying project upx. I am a project Member of upx.)

[maflcko]

lgtm. This is no longer needed, as clang was bumped in oss-fuzz.

[jreiser]

This pull request was approved yesterday by @maflcko but did not get applied in time for a build which failed this morning https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=66785#c16 . Why not?

[Edit] The Actions page https://github.com/google/oss-fuzz/actions/runs/8940978935/job/24563455468?pr=11896 shows 5 successes (green checkmark icons adjacent to jobs) and 6 failures (red X icons on jobs). The failures all are

+ for fuzzer in $(find $SRC -name '*_fuzzer.cpp')
++ basename -s .cpp /src/upx/fuzzers/list_packed_file_fuzzer.cpp
+ fuzz_basename=list_packed_file_fuzzer
+ cmake --build . --target list_packed_file_fuzzer -v
make: *** No rule to make target 'list_packed_file_fuzzer'.  Stop.
ERROR:__main__:Building fuzzers failed.

So this looks like inconsistent propagation of the pull request, because there were no changes elsewhere.

[maflcko]

This pull request was approved yesterday by @maflcko but did not get applied in time for a build which failed this morning https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=66785#c16 . Why not?

A maintainer needs to merge it first. (I am not a maintainer here)

So this looks like inconsistent propagation of the pull request, because there were no changes elsewhere.

The failures are real. This happens because the patch is no longer applied. You can either apply the patch in the build script here (you can also use patch -p1, which is less strict than git apply), or you can apply the patch (and fuzz targets) upstream, which would be https://google.github.io/oss-fuzz/advanced-topics/ideal-integration/ .