Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Go 1.22 #11677

Merged
merged 2 commits into from
May 6, 2024
Merged

Upgrade to Go 1.22 #11677

merged 2 commits into from
May 6, 2024

Conversation

justindhillon
Copy link
Contributor

New version of Go came out, so I have upgrade the version used in this project from 1.21 --> 1.22.

This PR is very similar to #10920

This fixes #11661

Copy link

github-actions bot commented Mar 8, 2024

justindhillon is a new contributor to projects/cryptofuzz. The PR must be approved by known contributors before it can be merged. The past contributors are: gilles-peskine-arm, skrah, guidovranken, DonggeLiu, jschwartzentruber

@jonathanmetzman
Copy link
Contributor

/gcbrun trial_build.py go --engine libfuzzer --sanitizer address

@justindhillon
Copy link
Contributor Author

/gcbrun trial_build.py go --engine libfuzzer --sanitizer address

I'm sorry, what does this mean?

@DavidKorczynski
Copy link
Collaborator

I'm sorry, what does this mean?

It's something internal to do testing on the infrastructure (please don't type the commands as one needs permissions)

@DavidKorczynski
Copy link
Collaborator

/gcbrun trial_build.py go --fuzzing-engines libfuzzer --sanitizers coverage address

@jonathanmetzman
Copy link
Contributor

I think this introduces a build error in cryptofuzz but otherwise looks OK to merge.

@jonathanmetzman
Copy link
Contributor

/gcbrun trial_build.py golang litmuschaos --fuzzing-engines libfuzzer --sanitizers coverage address

@jonathanmetzman
Copy link
Contributor

/gcbrun trial_build.py golang litmuschaos --fuzzing-engines libfuzzer --sanitizers coverage address

@jonathanmetzman
Copy link
Contributor

@catenacyber @guidovranken @AdamKorcz Could one of you PTAL at the golang failures caused by this PR? It's the only project that is failing.

@AdamKorcz
Copy link
Collaborator

@catenacyber @guidovranken @AdamKorcz Could one of you PTAL at the golang failures caused by this PR? It's the only project that is failing.

Sure, but I can also fix the build right after this PR lands if golang is the only project that fails.

@AdamKorcz
Copy link
Collaborator

@catenacyber @guidovranken @AdamKorcz Could one of you PTAL at the golang failures caused by this PR? It's the only project that is failing.

Most fuzzers build just fine. It looks like an easy fix that does not need to block this PR.

@jonathanmetzman jonathanmetzman merged commit 39f9a78 into google:master May 6, 2024
13 of 19 checks passed
DavidKorczynski pushed a commit that referenced this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Golang 1.22
4 participants