Add support for Apache Kafka log source #940
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why use Apache Kafka
In our environment, it is difficult for me to deploy a local log analysis tool directly on the machine. Fortunately, they have collected the logs into Kafka. I only need to consume them in Kafka.
About Unit Test
I wrote a simple unit test with reference to TestFileStreamRead. But I started a Kafka container locally before running the unit test, so the unit test will fail if directly
make check test
.But I have been running it in our production environment for a week, and process about 100 million Kafka messages every day.
About not using waker
Each message in Kafka is a log line, there is no need to use LineReader to find line endings, so I did not use waker.Waker.
Only handled
ctx done
andnetwork connection error
.