Add workflow to build and test ml-metadata #206
Conversation
There was a problem hiding this comment.
We also need the part of the workflow that automatically uploads to PyPI when a release is made. See https://github.com/tensorflow/tfx/blob/master/.github/workflows/wheels.yml for an example of how to do this.
There was a problem hiding this comment.
Usually I like to split builds and testing because they're separate concerns, but in this case building takes a LONG time if I remember correctly so I could be convinced here that this is a better approach. The only other thing is that absltest.TestCase is a child class of unittest.TestCase, so I'd be interested to know if replacing absltest.TestCase is strictly necessary; otherwise I think we don't need that change. But I don't think this should block merging.
- move pytest.ini to pyproject.toml - reusable steps instead
|
Hi, could you resolve the conflicts in this branch? |
Done, thanks! |
aktech
changed the title
|
@XinranTang Is there anything I can do to help out here? It would be nice to get this merged if possible. |
|
Hi, could you please check the pre-commit check? Thanks! |
This PR creates an action to build
ml-metadatapackage via docker.Passing here on my fork: https://github.com/aktech/ml-metadata/actions/runs/11081764726/job/30793914107
Note:
Since the tests uses abseil, with class based tests, I have removed the class which it subclasses to unittest as there is better compatibility of pytest with unittest. Removing all the class based test wouldn't have been wise as that would require finding compatible equivalents and replacing all instances, which should better be done in parts instead of in one go, if the team decided to get completely rid of abseil.
Removed flags from abseil to use pytest addoption