ci: update upload-artifact and download-artifact actions to v4
#8496
Conversation
|
Thanks for the PR! Slight issue we need to solve first is that v4 has the following breaking change:
|
| name: qa | ||
| name: qa-diffbrowsers-${{ matrix.os }} |
| name: qa | ||
| name: qa-diffenator |
There was a problem hiding this comment.
@m4rc1e Only this workflow is affected by the breaking change. I have also updated both artifact names to ensure they are unique.
There was a problem hiding this comment.
Thank you very much!
In order to test this pr, we need to trigger the action to run on a family. Would you mind adding another commit that changes https://github.com/google/fonts/blob/main/ofl/abel/METADATA.pb#L4 from SANS_SERIF to SERIF. If we're happy with the results, we'll delete the test commit.
There was a problem hiding this comment.
It looks like the secrets are not available in my forked repository.
Reference: google#8496 (comment) Signed-off-by: Eng Zer Jun <[email protected]>
|
We're also dealing with a failing CI due to a fontbakery error so this isn't your fault. I'm happy to merge this and finish it off on Monday. From what I've read in the upload repo, I'll need to consolidate the zips in a separate job, https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md#multiple-uploads-to-the-same-named-artifact I'm not going to merge it today since I adhere to "no deploy Fridays" for critical stuff ;-) |
Juneezee
force-pushed
the
ci/gh-actions-artifact
branch
from
388f1bc to
0dc1e1b
Compare
|
Rebased. |
v3 of `actions/upload-artifact` and `actions/download-artifact` will be fully deprecated by 5 December 2024 [1][2]. [1]: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ [2]: https://github.blog/changelog/2024-11-05-notice-of-breaking-changes-for-github-actions/ Signed-off-by: Eng Zer Jun <[email protected]>
Juneezee
force-pushed
the
ci/gh-actions-artifact
branch
from
0dc1e1b to
890a9dc
Compare
|
Rebased. |
v3 of
actions/upload-artifactandactions/download-artifactwill be fully deprecated by 5 December 2024. Jobs that are scheduled to run during the brownout periods will also fail. See:An attempt was made to update the artifact actions in PR #8159, but the version was eventually downgraded from
v4tov3due to artifact name conficts in PR #8210. This is because v4 ofactions/upload-artifactdoes not allow uploading to the same artifact name anymore and we need to give each artifact a unique name. See:/cc @simoncozens @m4rc1e