Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edu AU VIC WA NT Cursive: Version 1.001 added #8320

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Edu AU VIC WA NT Cursive: Version 1.001 added #8320

wants to merge 3 commits into from

Conversation

simoncozens
Copy link
Collaborator

@simoncozens simoncozens mentioned this pull request Oct 11, 2024
Closed
9 tasks
@simoncozens simoncozens linked an issue Oct 11, 2024 that may be closed by this pull request
Add Edu VIC WA NT Cursive #8307
Open
@github-actions GitHub Actions
Copy link

FontBakery report

fontbakery version: 0.13.0a1

Check results

[20] EduAUVICWANTCursive[wght].ttf
🔥 FAIL Combined length of family and style must not exceed 32 characters.
  • 🔥 FAIL

    Variable font instance name 'Edu AU VIC WA NT Cursive SemiBold' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 280 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long]
🔥 FAIL Shapes languages in all GF glyphsets.
  • 🔥 FAIL

    GF_Phonetics_SinoExt glyphset:

FAIL messages Languages
Shaper didn't attach ogonekcomb to idotless.fina lt_Latn (Lithuanian)
[code: failed-language-shaping]
  • ⚠️ WARN

    GF_Phonetics_SinoExt glyphset:

WARN messages Languages
Some auxiliary glyphs were missing: Ŀ, ŀ ca_Latn (Catalan)
Some auxiliary glyphs were missing: ſ de_Latn (German) and fr_Latn (French)
Some auxiliary glyphs were missing: Ŧ, ŧ, Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ fi_Latn (Finnish)
Some auxiliary glyphs were missing: Ŧ, ŧ nb_Latn (Norwegian Bokmål)
[code: warning-language-shaping]
🔥 FAIL Check font has a license.
  • 🔥 FAIL

    No license file was found. Please add an OFL.txt or a LICENSE.txt file. If you are running fontbakery on a Google Fonts upstream repo, which is fine, just make sure there is a temporary license file in the same folder.


    [code: no-license]
⚠️ WARN Ensure files are not too large.
  • ⚠️ WARN

    Font file is 1.2Mb; ideally it should be less than 1.0Mb


    [code: large-font]
⚠️ WARN Is there kerning info for non-ligated sequences?
  • ⚠️ WARN

    GPOS table lacks kerning info for the following non-ligated sequences:

- f + i

- f + l

[code: lacks-kern-info]

⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 1017 among a set of 4 math glyphs.
    The following math glyphs have a different width, though:

Width = 961: less

Width = 962: greater

Width = 1042: plusminus

Width = 1011: multiply

Width = 1052: approxequal

Width = 1037: notequal

Width = 1039: lessequal, greaterequal

[code: width-outliers]
⚠️ WARN Font has **proper** whitespace glyph names?
  • ⚠️ WARN

    Glyph 0x00A0 is called "nbspace": Change to "uni00A0"


    [code: not-recommended-00a0]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Family metadata at ofl/eduauvicwantcursive does not have an article.


    [code: lacks-article]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: tifinagh, cherokee, coptic, math
  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
  • U+0307 COMBINING DOT ABOVE: try adding one of: syriac, hebrew, canadian-aboriginal, tifinagh, math, tai-le, old-permic, duployan, todhri, coptic, malayalam
  • U+030A COMBINING RING ABOVE: try adding one of: syriac, duployan
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: osage, cherokee
  • U+030C COMBINING CARON: try adding one of: cherokee, tai-le
  • U+0312 COMBINING TURNED COMMA ABOVE: try adding math 35 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu

[code: unreachable-subsetting]
⚠️ WARN Check font follows the Google Fonts vertical metric schema
  • ⚠️ WARN

    We recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.7395x (3479)


    [code: bad-hhea-range]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/eduauvicwantcursive


    [code: family-path]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/eduauvicwantcursive/EduAUVICWANTCursive[wght].ttf
Dehinted Size 1.2Mb
Hinted Size 1.2Mb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

- vhea

- vmtx

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
  • ℹ️ INFO

    This font doesn't have an ARTICLE.en_us.html file.


    [code: missing-article]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table.

  • ℹ️ INFO

    Latn


    [code: dlng-tag]

  • ℹ️ INFO

    Latn


    [code: slng-tag]

ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.001']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 3 7 48 11 184 0
0% 0% 1% 3% 19% 4% 73% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@emmamarichal
Copy link
Collaborator

Hi @simoncozens!

🔥 FAIL Check font has a license.

Is there any reasons to remove the OFL.txt from the /ofl folder?

Here you can find some issues about outlines/anchors/connexions:
QA-Edu cursive
QA-Edu cursive2
QA-Edu cursive3

@emmamarichal emmamarichal added the -- Needs Upstream Resolution Upstream fix required before moving forward label Oct 24, 2024
@simoncozens
Copy link
Collaborator Author

Is there any reasons to remove the OFL.txt from the /ofl folder?

No, I did something silly in gftools-packager.

I'll take a look at the outline issues next week.

@simoncozens simoncozens removed the -- Needs Upstream Resolution Upstream fix required before moving forward label Nov 11, 2024
@github-actions GitHub Actions
Copy link

FontBakery report

fontbakery version: 0.13.0a5

Check results

[18] EduAUVICWANTCursive[wght].ttf
🔥 FAIL Combined length of family and style must not exceed 32 characters.
  • 🔥 FAIL

    Variable font instance name 'Edu AU VIC WA NT Cursive SemiBold' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 274 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long]
🔥 FAIL Shapes languages in all GF glyphsets.
  • 🔥 FAIL

    GF_Phonetics_SinoExt glyphset:

FAIL messages Languages
Shaper didn't attach ogonekcomb to idotless.fina lt_Latn (Lithuanian)
[code: failed-language-shaping]
  • ⚠️ WARN

    GF_Phonetics_SinoExt glyphset:

WARN messages Languages
Some auxiliary glyphs were missing: Ŀ, ŀ ca_Latn (Catalan)
Some auxiliary glyphs were missing: ſ de_Latn (German) and fr_Latn (French)
Some auxiliary glyphs were missing: Ŧ, ŧ, Ʒ, Ǥ, ǥ, Ǯ, ǯ, ʒ fi_Latn (Finnish)
Some auxiliary glyphs were missing: Ŧ, ŧ nb_Latn (Norwegian Bokmål)
[code: warning-language-shaping]
⚠️ WARN Ensure files are not too large.
  • ⚠️ WARN

    Font file is 1.2Mb; ideally it should be less than 1.0Mb


    [code: large-font]
⚠️ WARN Is there kerning info for non-ligated sequences?
  • ⚠️ WARN

    GPOS table lacks kerning info for the following non-ligated sequences:

- f + i

- f + l

[code: lacks-kern-info]

⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 1017 among a set of 4 math glyphs.
    The following math glyphs have a different width, though:

Width = 961: less

Width = 962: greater

Width = 1042: plusminus

Width = 1011: multiply

Width = 1052: approxequal

Width = 1037: notequal

Width = 1039: greaterequal, lessequal

[code: width-outliers]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Family metadata at ofl/eduauvicwantcursive does not have an article.


    [code: lacks-article]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
  • U+02DB OGONEK: try adding one of: yi, canadian-aboriginal
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: tifinagh, coptic, math, cherokee
  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
  • U+0307 COMBINING DOT ABOVE: try adding one of: tai-le, canadian-aboriginal, coptic, math, hebrew, duployan, malayalam, syriac, tifinagh, todhri, old-permic
  • U+030A COMBINING RING ABOVE: try adding one of: syriac, duployan
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage
  • U+030C COMBINING CARON: try adding one of: tai-le, cherokee
  • U+0312 COMBINING TURNED COMMA ABOVE: try adding math 35 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu

[code: unreachable-subsetting]
⚠️ WARN Check font follows the Google Fonts vertical metric schema
  • ⚠️ WARN

    We recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.7395x (3479)


    [code: bad-hhea-range]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/eduauvicwantcursive


    [code: family-path]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/eduauvicwantcursive/EduAUVICWANTCursive[wght].ttf
Dehinted Size 1.2Mb
Hinted Size 1.2Mb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

- vhea

- vmtx

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
  • ℹ️ INFO

    This font doesn't have an ARTICLE.en_us.html file.


    [code: missing-article]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table.

  • ℹ️ INFO

    Latn


    [code: dlng-tag]

  • ℹ️ INFO

    Latn


    [code: slng-tag]

ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.002']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 2 6 45 11 188 0
0% 0% 1% 2% 18% 4% 75% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@vv-monsalve
Copy link
Collaborator

vv-monsalve commented Nov 13, 2024 •
edited
Loading

Hi @simoncozens, @EbenSorkin

Some of the issues mentioned above are still present in the font. I have created a PDF that includes these findings and additional ones. Please review this document and any other findings you might come across while addressing the items mentioned above so we can prepare for a final PR update.

edu-au-vic-wa-nt-cursive.pdf

@vv-monsalve vv-monsalve added the -- Needs Upstream Resolution Upstream fix required before moving forward label Nov 13, 2024
@emmamarichal
Copy link
Collaborator

Hi there! @EbenSorkin @simoncozens what is the status here?

@simoncozens
Copy link
Collaborator Author

I haven't done any outline fixes based on Viviana's feedback yet. @EbenSorkin do you have time to work on this font or should I get to it when I can?

@EbenSorkin
Copy link
Collaborator

EbenSorkin commented Dec 4, 2024 via email

@EbenSorkin
Copy link
Collaborator

EbenSorkin commented Dec 4, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
-- Needs Upstream Resolution Upstream fix required before moving forward I New Font
Projects
Fonts Traffic Jam
Status: PR GF
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Edu VIC WA NT Cursive
4 participants
@simoncozens @emmamarichal @vv-monsalve @EbenSorkin