-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noto Nastaliq Urdu: Version 4.000 added #7950
base: main
Are you sure you want to change the base?
Conversation
Taken from the upstream repo https://github.com/notofonts/nastaliq at commit notofonts/nastaliq@9887ddf.
This is a new major release; when looking at the diffenator report, expect substantial change!
|
FontBakery reportfontbakery version: 0.12.8 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [2] NotoNastaliqUrdu[wght].ttfAll other checks[17] NotoNastaliqUrdu[wght].ttf🔥 FAIL Shapes languages in all GF glyphsets.
🔥 FAIL Does DESCRIPTION file contain broken links?
|
ofl/notonastaliqurdu/NotoNastaliqUrdu[wght].ttf | |
---|---|
Dehinted Size | 317.4kb |
Hinted Size | 317.5kb |
Increase | 24 bytes |
Change | 0.0 % |
[1] Family checks
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 3 | 8 | 45 | 9 | 186 | 0 |
0% | 0% | 1% | 3% | 18% | 4% | 74% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
@simoncozens Qq, I'm guessing there are empty glyphs since the shaping engine eventually picks an isol, init, medi or fina form so they're kinda redundant? |
No isol feature, but those particular glyphs are empty because they're immediately decomposed into base glyph + dot glyph in ccmp. |
I see some interpolations issues left: The '9' looks more problematic: Screen.Recording.2024-07-31.at.15.36.00.mov |
Screen.Recording.2024-07-31.at.15.44.34.movScreen.Recording.2024-07-31.at.15.45.05.movScreen.Recording.2024-07-31.at.15.46.31.mov |
@simoncozens I'm checking the opened PRs, have you seen this? |
I'm working on these plus a few shaping issues reported by the community. |
I facing an issue with this font over mobile webview(capacitorjs). Suddenly application got stuck but when i use other urdu font like gulzar it works fine |
Taken from the upstream repo https://github.com/notofonts/nastaliq at commit notofonts/nastaliq@9887ddf.
PR Checklist:
minisite_url
definition in the METADATA.pb file for commissioned projectsprimary_script
definition in the METADATA.pb file for all projects that have a primary non-Latin based language support targetsubsets
definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsetschinese-hongkong
,chinese-simplified
,chinese-traditional
,korean
,japanese
.