[Proof-of-concept] Automated hotfixes #7842
Conversation
FontBakery reportfontbakery version: 0.12.7 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [2] ABeeZee-Regular.ttf[2] ABeeZee-Italic.ttfAll other checks[27] ABeeZee-Regular.ttf💥 ERROR Check if the vertical metrics of a CJK family are similar to the same family hosted on Google Fonts.
💥 ERROR Check if the vertical metrics of a family are similar to the same family hosted on Google Fonts.
🔥 FAIL Ensure the font supports case swapping for all its glyphs.
🔥 FAIL Check if each glyph has the recommended amount of contours.
[code: no-contour]
The following glyphs do not have the recommended number of contours: 🔥 FAIL Shapes languages in all GF glyphsets.
🔥 FAIL Check family name for GF Guide compliance.
🔥 FAIL Check Google Fonts glyph coverage.
Use -F or --full-lists to disable shortening of long lists. [code: missing-codepoints]
|
| Glyph present in the font | Missing case-swapping counterpart |
|---|---|
| U+0137: LATIN SMALL LETTER K WITH CEDILLA | U+0136: LATIN CAPITAL LETTER K WITH CEDILLA |
🔥 FAIL Check if each glyph has the recommended amount of contours.
- 🔥 FAIL
The following glyphs have no contours even though they were expected to have some:
- Glyph name: uni2215 Expected: 1
- Glyph name: uni2215 Expected: 1
[code: no-contour]
⚠️ WARNThis check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.
The following glyphs do not have the recommended number of contours:
- Glyph name: Racute Contours detected: 3 Expected: 2
🔥 FAIL Shapes languages in all GF glyphsets.
- 🔥 FAIL
No GF glyphset was found to be supported >80%, so language shaping support couldn't get checked.
[code: no-glyphset-supported]
🔥 FAIL Check family name for GF Guide compliance.
- 🔥 FAIL
"ABeeZee" contains an abbreviation.
[code: abbreviation]
🔥 FAIL Check Google Fonts glyph coverage.
- 🔥 FAIL
Missing required codepoints:
- 0x0100 (LATIN CAPITAL LETTER A WITH MACRON)
- 0x0101 (LATIN SMALL LETTER A WITH MACRON)
- 0x0102 (LATIN CAPITAL LETTER A WITH BREVE)
- 0x0103 (LATIN SMALL LETTER A WITH BREVE)
- 0x0104 (LATIN CAPITAL LETTER A WITH OGONEK)
- 0x0105 (LATIN SMALL LETTER A WITH OGONEK)
- 0x0106 (LATIN CAPITAL LETTER C WITH ACUTE)
- 0x0107 (LATIN SMALL LETTER C WITH ACUTE)
- 0x010A (LATIN CAPITAL LETTER C WITH DOT ABOVE)
- 0x010B (LATIN SMALL LETTER C WITH DOT ABOVE)
- 86 more.
Use -F or --full-lists to disable shortening of long lists.
[code: missing-codepoints]⚠️ WARN Check font contains no unreachable glyphs
⚠️ WARNThe following glyphs could not be reached by codepoint or substitution rules:
- foundryicon
- uni00AD
[code: unreachable-glyphs]
⚠️ WARN Are there any misaligned on-curve points?
⚠️ WARNThe following glyphs have on-curve points which have potentially incorrect y coordinates:
* B (U+0042): X=130.0,Y=-1.5 (should be at baseline 0?)
* K (U+004B): X=537.0,Y=698.0 (should be at cap-height 700?)
* ae (U+00E6): X=725.0,Y=0.5 (should be at baseline 0?)
* c (U+0063): X=341.5,Y=-2.0 (should be at baseline 0?)
* c (U+0063): X=403.5,Y=520.5 (should be at x-height 520?)
* ccedilla (U+00E7): X=341.5,Y=-2.0 (should be at baseline 0?)
* e (U+0065): X=363.0,Y=0.5 (should be at baseline 0?)
* eacute (U+00E9): X=363.0,Y=0.5 (should be at baseline 0?)
* ecircumflex (U+00EA): X=363.0,Y=0.5 (should be at baseline 0?)
* edieresis (U+00EB): X=363.0,Y=0.5 (should be at baseline 0?)
* 17 more.
Use -F or --full-lists to disable shortening of long lists.
[code: found-misalignments]⚠️ WARN Are any segments inordinately short?
⚠️ WARNThe following glyphs have segments which seem very short:
* G (U+0047) contains a short segment B<<573.0,146.0>-<572.0,141.0>-<571.5,134.5>>
* G (U+0047) contains a short segment B<<571.5,134.5>-<571.0,128.0>-<571.0,121.0>>
* U (U+0055) contains a short segment B<<561.0,146.0>-<560.0,141.0>-<559.5,134.5>>
* U (U+0055) contains a short segment B<<559.5,134.5>-<559.0,128.0>-<559.0,121.0>>
* Uacute (U+00DA) contains a short segment B<<561.0,146.0>-<560.0,141.0>-<559.5,134.5>>
* Uacute (U+00DA) contains a short segment B<<559.5,134.5>-<559.0,128.0>-<559.0,121.0>>
* Ucircumflex (U+00DB) contains a short segment B<<561.0,146.0>-<560.0,141.0>-<559.5,134.5>>
* Ucircumflex (U+00DB) contains a short segment B<<559.5,134.5>-<559.0,128.0>-<559.0,121.0>>
* Udieresis (U+00DC) contains a short segment B<<561.0,146.0>-<560.0,141.0>-<559.5,134.5>>
* Udieresis (U+00DC) contains a short segment B<<559.5,134.5>-<559.0,128.0>-<559.0,121.0>>
* 38 more.
Use -F or --full-lists to disable shortening of long lists.
[code: found-short-segments]⚠️ WARN Do any segments have colinear vectors?
⚠️ WARNThe following glyphs have colinear vectors:
* exclam (U+0021): L<<108.0,207.0>--<143.0,480.0>> -> L<<143.0,480.0>--<187.0,729.0>>
* exclam (U+0021): L<<287.0,729.0>--<243.0,480.0>> -> L<<243.0,480.0>--<182.0,207.0>>
* exclamdown (U+00A1): L<<209.0,314.0>--<174.0,41.0>> -> L<<174.0,41.0>--<127.0,-220.0>>
* exclamdown (U+00A1): L<<27.0,-220.0>--<74.0,41.0>> -> L<<74.0,41.0>--<135.0,314.0>>
[code: found-colinear-vectors]
⚠️ WARN Ensure dotted circle glyph is present and can attach marks.
⚠️ WARNNo dotted circle glyph present
[code: missing-dotted-circle]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.
⚠️ WARNThe dot of soft dotted characters should disappear in other cases, for example: ī̦ i̦̇ i̦̊ ǐ̦ j̦̀ j̦́ j̦̃ j̦̄ j̦̇ j̦̈ j̦̊ ǰ̦
Your font fully covers the following languages that require the soft-dotted feature: Dutch (Latn, 31,709,104 speakers).
Your font does not cover the following languages that require the soft-dotted feature: Fur (Latn, 1,230,163 speakers), Yala (Latn, 200,000 speakers), Zapotec (Latn, 490,000 speakers), Ma’di (Latn, 584,000 speakers), Mango (Latn, 77,000 speakers), Ekpeye (Latn, 226,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Cicipu (Latn, 44,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), Mfumte (Latn, 79,000 speakers), Nateni (Latn, 100,000 speakers), Dan (Latn, 1,099,244 speakers), Nzakara (Latn, 50,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Navajo (Latn, 166,319 speakers), Kom (Latn, 360,685 speakers), Ejagham (Latn, 120,000 speakers), Bafut (Latn, 158,146 speakers), Lithuanian (Latn, 2,357,094 speakers), South Central Banda (Latn, 244,000 speakers), Basaa (Latn, 332,940 speakers), Gulay (Latn, 250,478 speakers), Dii (Latn, 71,000 speakers), Sar (Latn, 500,000 speakers), Mundani (Latn, 34,000 speakers), Igbo (Latn, 27,823,640 speakers), Koonzime (Latn, 40,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Aghem (Latn, 38,843 speakers), Lugbara (Latn, 2,200,000 speakers), Ebira (Latn, 2,200,000 speakers), Southern Kisi (Latn, 360,000 speakers), Avokaya (Latn, 100,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Makaa (Latn, 221,000 speakers), Vute (Latn, 21,000 speakers), Bete-Bendi (Latn, 100,000 speakers).
[code: soft-dotted]⚠️ WARN METADATA.pb: Designers are listed correctly on the Google Fonts catalog?
⚠️ WARNIt seems that Anja Meiners is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry.
[code: profile-not-found]
⚠️ WARN Copyright notice on METADATA.pb should not contain 'Reserved Font Name'.
⚠️ WARNMETADATA.pb: copyright field ("Copyright 2011 The ABeeZee Project Authors (https://github.com/googlefonts/abeezee) with Reserved Font Name ABeeZee") contains "Reserved Font Name". This is an error except in a few specific rare cases.
[code: rfn]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
⚠️ WARNThe following codepoints supported by the font are not covered by
any subsets defined in the font's metadata file, and will never
be served. You can solve this by either manually adding additional
subset declarations to METADATA.pb, or by editing the glyphset
definitions.
- U+02C7 CARON: try adding one of: yi, canadian-aboriginal, tifinagh
- U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
- U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: math, coptic, cherokee, tifinagh
- U+0307 COMBINING DOT ABOVE: try adding one of: syriac, old-permic, malayalam, math, tai-le, tifinagh, coptic, canadian-aboriginal
- U+030A COMBINING RING ABOVE: try adding syriac
- U+030C COMBINING CARON: try adding one of: tai-le, cherokee
- U+0326 COMBINING COMMA BELOW: not included in any glyphset definition
- U+0327 COMBINING CEDILLA: not included in any glyphset definition
Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu
⚠️ WARN On a family update, the DESCRIPTION.en_us.html file should ideally also be updated.
⚠️ WARNThe DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
Please consider mentioning note-worthy improvements made to the family recently.
[code: description-not-updated]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
⚠️ WARNThis font file does not have a 'meta' table.
[code: lacks-meta-table]
⚠️ WARN Font has old ttfautohint applied?
⚠️ WARNttfautohint used in font = 1.8.3; latest = 1.8.4; Need to re-run with the newer version!
[code: old-ttfa]
⚠️ WARN Checking OS/2 achVendID.
⚠️ WARNOS/2 VendorID is 'PYRS', a font editor default. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
[code: bad]
ℹ️ INFO Font contains all required tables?
- ℹ️ INFO
This font contains the following optional tables:
- cvt
- fpgm
- loca
- prep
- GPOS
- GSUB
- gasp
[code: optional-tables]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
- ℹ️ INFO
Found a git repo URL: https://github.com/googlefonts/abeezee
[code: url-found]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
- ℹ️ INFO
This font doesn't have an ARTICLE.en_us.html file.
[code: missing-article]
ℹ️ INFO EPAR table present in font?
- ℹ️ INFO
EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818
[code: lacks-EPAR]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges][1] Family checks
Summary
| 💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
|---|---|---|---|---|---|---|---|
| 4 | 0 | 10 | 28 | 120 | 17 | 299 | 0 |
| 1% | 0% | 2% | 6% | 25% | 4% | 63% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
vv-monsalve
added
the
-- Needs Eng team opinion
|
Internal comment from @simoncozens:
@rsheeter Should anything happen in preparation for this PR to be landed, or would it be ready for review? |
This is the first of a (potential) series of PRs related to #7358. It uses the fontrefinery tool to automate hotfixing various fontbakery problems. The report below shows, for each family, the fontbakery status before and after the fix and the fixes applied.
abeezee
ABeeZee-Italic.ttf
ABeeZee-Regular.ttf
abel
Abel-Regular.ttf
abhayalibre
AbhayaLibre-Bold.ttf
AbhayaLibre-Regular.ttf
AbhayaLibre-Medium.ttf
AbhayaLibre-ExtraBold.ttf
AbhayaLibre-SemiBold.ttf
aboreto
Aboreto-Regular.ttf
abrilfatface
AbrilFatface-Regular.ttf
acme
Acme-Regular.ttf
actor
Actor-Regular.ttf
adamina
Adamina-Regular.ttf
agbalumo
Agbalumo-Regular.ttf
aguafinascript
AguafinaScript-Regular.ttf
akatab
Akatab-ExtraBold.ttf
Akatab-SemiBold.ttf
Akatab-Black.ttf
Akatab-Regular.ttf
Akatab-Medium.ttf
Akatab-Bold.ttf