Buenard: Version 2.000 added #7573

simoncozens · 2024-04-18T16:46:10Z

Taken from the upstream repo https://www.github.com/googlefonts/buenard at commit https://www.github.com/googlefonts/buenard/commit/4e9ae114c1180a9093d310e7985aa4e024e4901e.

github-actions · 2024-04-18T16:48:33Z

FontBakery report

fontbakery version: 0.12.2

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[2] Buenard[wght].ttf

⚠️

WARN Validate location, size and resolution of article images.

⚠️ WARN
Family metadata at ofl/buenard does not have an article.

[code: lacks-article]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.

ℹ️ INFO
Please consider adding a family.minisite_url entry.

[code: lacks-minisite-url]

All other checks

[16] Buenard[wght].ttf

⚠️

WARN Does GPOS table have kerning information? This check skips monospaced fonts as defined by post.isFixedPitch value

⚠️ WARN
GPOS table lacks kerning information.

[code: lacks-kern-info]

⚠️

WARN Check math signs have the same width.

⚠️ WARN
The most common width is 460 among a set of 6 math glyphs.
The following math glyphs have a different width, though:

Width = 469: greater, less

Width = 567: logicalnot

[code: width-outliers]

⚠️

WARN Check font contains no unreachable glyphs

⚠️ WARN
The following glyphs could not be reached by codepoint or substitution rules:

- CR

[code: unreachable-glyphs]

⚠️

WARN Check for codepoints not covered by METADATA subsets.

⚠️ WARN
The following codepoints supported by the font are not covered by
any subsets defined in the font's metadata file, and will never
be served. You can solve this by either manually adding additional
subset declarations to METADATA.pb, or by editing the glyphset
definitions.

U+02C7 CARON: try adding one of: canadian-aboriginal, yi, tifinagh
U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition
U+03BC GREEK SMALL LETTER MU: try adding one of: greek, math

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu

[code: unreachable-subsetting]

⚠️

WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.

⚠️ WARN
This font file does not have a 'meta' table.

[code: lacks-meta-table]

⚠️

WARN Checking OS/2 achVendID.

⚠️ WARN
OS/2 VendorID value 'NONE' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx

[code: unknown]

ℹ️ INFO List all superfamily filepaths

ℹ️ INFO
ofl/buenard

[code: family-path]

ℹ️ INFO Font contains all required tables?

ℹ️ INFO
This font contains the following optional tables:

- loca

- prep

- gasp

[code: optional-tables]

ℹ️ INFO EPAR table present in font?

ℹ️ INFO
EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818

[code: lacks-EPAR]

ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?

ℹ️ INFO
These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]

ℹ️ INFO Show hinting filesize impact.

ℹ️ INFO
Hinting filesize impact:

	ofl/buenard/Buenard[wght].ttf
Dehinted Size	42.5kb
Hinted Size	42.5kb
Increase	24 bytes
Change	0.1 %

[code: size-impact]

ℹ️ INFO Font has old ttfautohint applied?

ℹ️ INFO
Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.000']

[code: version-not-detected]

🔥 FAIL Ensure the font supports case swapping for all its glyphs.

🔥 FAIL
The following glyphs lack their case-swapping counterparts:

Glyph present in the font	Missing case-swapping counterpart
U+0129: LATIN SMALL LETTER I WITH TILDE	U+0128: LATIN CAPITAL LETTER I WITH TILDE
U+0133: LATIN SMALL LIGATURE IJ	U+0132: LATIN CAPITAL LIGATURE IJ
U+0135: LATIN SMALL LETTER J WITH CIRCUMFLEX	U+0134: LATIN CAPITAL LETTER J WITH CIRCUMFLEX
U+0177: LATIN SMALL LETTER Y WITH CIRCUMFLEX	U+0176: LATIN CAPITAL LETTER Y WITH CIRCUMFLEX
U+1EF3: LATIN SMALL LETTER Y WITH GRAVE	U+1EF2: LATIN CAPITAL LETTER Y WITH GRAVE

[code: missing-case-counterparts]

🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.

🔥 FAIL
Repository URL is https://www.github.com/googlefonts/buenard

But: font copyright string has 'https://github.com/googlefonts/buenard' and OFL text has 'https://github.com/googlefonts/buenard'

[code: mismatch]

🔥 FAIL Does DESCRIPTION file contain a upstream Git repo URL?

🔥 FAIL
Please host your font project on a public Git repo (such as GitHub or GitLab) and place a link in the DESCRIPTION.en_us.html file.

[code: lacks-git-url]

🔥 FAIL Check Google Fonts glyph coverage.

🔥 FAIL
Missing required codepoints:

- 0x00AF (MACRON)


- 0x0100 (LATIN CAPITAL LETTER A WITH MACRON)


- 0x0101 (LATIN SMALL LETTER A WITH MACRON)


- 0x0102 (LATIN CAPITAL LETTER A WITH BREVE)


- 0x0103 (LATIN SMALL LETTER A WITH BREVE)


- 0x0104 (LATIN CAPITAL LETTER A WITH OGONEK)


- 0x0105 (LATIN SMALL LETTER A WITH OGONEK)


- 0x0106 (LATIN CAPITAL LETTER C WITH ACUTE)


- 0x0107 (LATIN SMALL LETTER C WITH ACUTE)


- 0x010A (LATIN CAPITAL LETTER C WITH DOT ABOVE)


- 103 more.

Use -F or --full-lists to disable shortening of long lists.

[code: missing-codepoints]

[1] Family checks

ℹ️ INFO Check axis ordering on the STAT table.

ℹ️ INFO
None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1)

[code: summary]

Summary

💥 ERROR	☠ FATAL	🔥 FAIL	⚠️ WARN	⏩ SKIP	ℹ️ INFO	✅ PASS	🔎 DEBUG
0	0	4	7	44	8	186	0
0%	0%	2%	3%	18%	3%	75%	0%

Note: The following loglevels were omitted in this report:

SKIP
PASS
DEBUG

m4rc1e · 2024-04-24T14:28:37Z

Many glyphs seem to have been removed. I don't think we can release this.

simoncozens · 2024-04-29T14:07:50Z

I pulled the glyphs from the existing fonts (which were not in the sources I got from the designer, so someone must have added them at some point...) and rebuilt them out of components.

github-actions · 2024-05-16T12:30:15Z

FontBakery report

fontbakery version: 0.12.6

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[2] Buenard[wght].ttf

⚠️

WARN Validate location, size and resolution of article images.

⚠️ WARN
Family metadata at ofl/buenard does not have an article.

[code: lacks-article]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.

ℹ️ INFO
Please consider adding a family.minisite_url entry.

[code: lacks-minisite-url]

All other checks

[18] Buenard[wght].ttf

🔥 FAIL Shapes languages in all GF glyphsets.

🔥 FAIL
GF_Latin_Core glyphset:

Language	FAIL messages
de_Latn (German)	Some base glyphs were missing: ẞ
^	Shaper produced a .notdef

[code: failed-language-shaping]

⚠️ WARN
GF_Latin_Core glyphset:

Language	WARN messages
de_Latn (German)	Some auxiliary glyphs were missing: ẞ

[code: warning-language-shaping]

🔥 FAIL Check Google Fonts glyph coverage.

🔥 FAIL
Missing required codepoints:

- 0x1E9E (LATIN CAPITAL LETTER SHARP S)

[code: missing-codepoints]

⚠️

WARN Does GPOS table have kerning information? This check skips monospaced fonts as defined by post.isFixedPitch value

⚠️ WARN
GPOS table lacks kerning information.

[code: lacks-kern-info]

⚠️

WARN Check math signs have the same width.

⚠️ WARN
The most common width is 460 among a set of 6 math glyphs.
The following math glyphs have a different width, though:

Width = 469: greater, less

Width = 567: logicalnot

[code: width-outliers]

⚠️

WARN Check font contains no unreachable glyphs

⚠️ WARN
The following glyphs could not be reached by codepoint or substitution rules:

- CR

[code: unreachable-glyphs]

⚠️

WARN Check the direction of the outermost contour in each glyph

⚠️ WARN
The following glyphs have a counter-clockwise outer contour:

* Agrave (U+00C0) has a counter-clockwise outer contour

* Aring (U+00C5) has a counter-clockwise outer contour

* Aringacute (U+01FA) has a counter-clockwise outer contour

* D (U+0044) has a counter-clockwise outer contour

* Dcaron (U+010E) has a counter-clockwise outer contour

* Egrave (U+00C8) has a counter-clockwise outer contour

* Eth (U+00D0) has a counter-clockwise outer contour

* Igrave (U+00CC) has a counter-clockwise outer contour

* Ograve (U+00D2) has a counter-clockwise outer contour

* R (U+0052) has a counter-clockwise outer contour

* 69 more.

Use -F or --full-lists to disable shortening of long lists.

[code: ccw-outer-contour]

⚠️

WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot.

⚠️ WARN
The dot of soft dotted characters should disappear in other cases, for example: i̅ ị̅ i̥̅ i̦̅ i̧̅ j̅ j̣̅ j̥̅ j̦̅ j̧̅ j̨̅ į̅ į̣̅ į̥̅ į̦̅ į̧̅ į̨̅

Your font fully covers the following languages that require the soft-dotted feature: Lithuanian (Latn, 2,357,094 speakers), Dutch (Latn, 31,709,104 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Dan (Latn, 1,099,244 speakers), Bete-Bendi (Latn, 100,000 speakers), Dii (Latn, 71,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Kom (Latn, 360,685 speakers), Mango (Latn, 77,000 speakers), Ma’di (Latn, 584,000 speakers), Sar (Latn, 500,000 speakers), Ejagham (Latn, 120,000 speakers), Yala (Latn, 200,000 speakers), Mundani (Latn, 34,000 speakers), Vute (Latn, 21,000 speakers), Zapotec (Latn, 490,000 speakers), Southern Kisi (Latn, 360,000 speakers), Fur (Latn, 1,230,163 speakers), Nateni (Latn, 100,000 speakers), Lugbara (Latn, 2,200,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Basaa (Latn, 332,940 speakers), Aghem (Latn, 38,843 speakers), Gulay (Latn, 250,478 speakers), Bafut (Latn, 158,146 speakers), Koonzime (Latn, 40,000 speakers), Nzakara (Latn, 50,000 speakers), Makaa (Latn, 221,000 speakers), Cicipu (Latn, 44,000 speakers), Ebira (Latn, 2,200,000 speakers), Navajo (Latn, 166,319 speakers), Igbo (Latn, 27,823,640 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Mfumte (Latn, 79,000 speakers), Avokaya (Latn, 100,000 speakers), Ekpeye (Latn, 226,000 speakers), Belarusian (Cyrl, 10,064,517 speakers), South Central Banda (Latn, 244,000 speakers), Ukrainian (Cyrl, 29,273,587 speakers).

[code: soft-dotted]

⚠️

WARN Check for codepoints not covered by METADATA subsets.

⚠️ WARN
The following codepoints supported by the font are not covered by
any subsets defined in the font's metadata file, and will never
be served. You can solve this by either manually adding additional
subset declarations to METADATA.pb, or by editing the glyphset
definitions.

U+02C7 CARON: try adding one of: tifinagh, canadian-aboriginal, yi
U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition
U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: math, coptic, tifinagh, cherokee
U+0305 COMBINING OVERLINE: try adding one of: gothic, glagolitic, coptic, elbasan, math
U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
U+0307 COMBINING DOT ABOVE: try adding one of: tai-le, malayalam, coptic, old-permic, math, syriac, tifinagh, canadian-aboriginal
U+030A COMBINING RING ABOVE: try adding syriac 16 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu

[code: unreachable-subsetting]

⚠️

WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.

⚠️ WARN
This font file does not have a 'meta' table.

[code: lacks-meta-table]

⚠️

WARN Checking OS/2 achVendID.

⚠️ WARN
OS/2 VendorID value 'NONE' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx

[code: unknown]

ℹ️ INFO List all superfamily filepaths

ℹ️ INFO
ofl/buenard

[code: family-path]

ℹ️ INFO Font contains all required tables?

ℹ️ INFO
This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

[code: optional-tables]

ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?

ℹ️ INFO
Found a git repo URL: https://github.com/googlefonts/buenard

[code: url-found]

ℹ️ INFO Check for presence of an ARTICLE.en_us.html file

ℹ️ INFO
This font doesn't have an ARTICLE.en_us.html file.

[code: missing-article]

ℹ️ INFO EPAR table present in font?

ℹ️ INFO
EPAR table not present in font. To learn more see When missing EPAR table, just emit INFO alert fonttools/fontbakery#818

[code: lacks-EPAR]

ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?

ℹ️ INFO
These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]

ℹ️ INFO Show hinting filesize impact.

ℹ️ INFO
Hinting filesize impact:

	ofl/buenard/Buenard[wght].ttf
Dehinted Size	70.5kb
Hinted Size	70.5kb
Increase	24 bytes
Change	0.0 %

[code: size-impact]

ℹ️ INFO Font has old ttfautohint applied?

ℹ️ INFO
Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.000']

[code: version-not-detected]

[1] Family checks

ℹ️ INFO Check axis ordering on the STAT table.

ℹ️ INFO
None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1)

[code: summary]

Summary

💥 ERROR	☠ FATAL	🔥 FAIL	⚠️ WARN	⏩ SKIP	ℹ️ INFO	✅ PASS	🔎 DEBUG
0	0	2	9	42	10	188	0
0%	0%	1%	4%	17%	4%	75%	0%

Note: The following loglevels were omitted in this report:

SKIP
PASS
DEBUG

emmamarichal · 2024-05-16T13:12:01Z

@simoncozens

Fontbakery report:

for the Germandbls cap, I usually add it and put 2 S into it, to avoid any tofu or issues.

Outlines:

There is no weight variation for the quotesingle and the yen

Screen.Recording.2024-05-16.at.15.02.16.mov

Screen.Recording.2024-05-16.at.15.00.53.mov

In regular, we have tofu for phẩm -> ẩ I don't have that issue in the Bold

Screen.Recording.2024-05-16.at.15.05.50.mov

emmamarichal · 2024-05-16T13:14:54Z

ofl/buenard/DESCRIPTION.en_us.html

+<p>
+ Buenard is a high-quality serif typeface for art books.
+ Its based on the Transitional Roman classical structure, with less contrasted strokes and heavier serifs.


Its -> It's

emmamarichal · 2024-05-16T13:15:32Z

ofl/buenard/OFL.txt

@@ -1,9 +1,8 @@
-Copyright (c) 2011, FontFuror ([email protected]), 
-with Reserved Font Names "Buenard" and "Buenard Pro".
+Copyright 2024 The Buenard Project Authors (https://github.com/googlefonts/buenard)


we don't keep 2011?

emmamarichal · 2024-06-25T12:28:20Z

@simoncozens, what is the status for that PR?

simoncozens added 2 commits April 18, 2024 17:44

Buenard: Version 2.000 added

7217e59

Taken from the upstream repo https://www.github.com/googlefonts/buenard at commit https://www.github.com/googlefonts/buenard/commit/4e9ae114c1180a9093d310e7985aa4e024e4901e.

Remove old statics and fontlog

0dbd99d

simoncozens added III VF Replacement Replace an existing family of static fonts with variable fonts I Font Upgrade labels Apr 18, 2024

simoncozens linked an issue Apr 18, 2024 that may be closed by this pull request

Update Buenard #7572

Open

m4rc1e added the -- Glyphset issue Missing glyphs to match a GF subset, wrong glyph mapping, unicode issue, or else label Apr 25, 2024

Latest build

8ae3662

simoncozens removed the -- Glyphset issue Missing glyphs to match a GF subset, wrong glyph mapping, unicode issue, or else label Apr 29, 2024

This comment was marked as outdated.

Sign in to view

Metadata and description

5a895e2

This comment was marked as outdated.

Sign in to view

emmamarichal reviewed May 16, 2024

View reviewed changes

vv-monsalve added the -- Needs Upstream Resolution Upstream fix required before moving forward label May 23, 2024

vv-monsalve mentioned this pull request Jul 6, 2024

Update Buenard font designer credit #7547

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Buenard: Version 2.000 added #7573

Buenard: Version 2.000 added #7573

simoncozens commented Apr 18, 2024

github-actions bot commented Apr 18, 2024

m4rc1e commented Apr 24, 2024

simoncozens commented Apr 29, 2024

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot commented May 16, 2024

emmamarichal commented May 16, 2024

emmamarichal May 16, 2024

emmamarichal May 16, 2024

emmamarichal commented Jun 25, 2024

Buenard: Version 2.000 added #7573

Are you sure you want to change the base?

Buenard: Version 2.000 added #7573

Conversation

simoncozens commented Apr 18, 2024

github-actions bot commented Apr 18, 2024

FontBakery report

Experimental checks

All other checks

Summary

m4rc1e commented Apr 24, 2024

simoncozens commented Apr 29, 2024

This comment was marked as outdated.

This comment was marked as outdated.

github-actions bot commented May 16, 2024

FontBakery report

Experimental checks

All other checks

Summary

emmamarichal commented May 16, 2024

emmamarichal May 16, 2024

Choose a reason for hiding this comment

emmamarichal May 16, 2024

Choose a reason for hiding this comment

emmamarichal commented Jun 25, 2024