Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pacifico: Version 3.010; ttfautohint (v1.8.4.7-5d5b) added #7309

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

emmamarichal
Copy link
Collaborator

1ae4e03: [gftools-packager] Pacifico: Version 3.010; ttfautohint (v1.8.4.7-5d5b) added

2def0d3: description and metadatas

@emmamarichal emmamarichal added I Font Upgrade II African Mostly west african non-latin and African indigenous scripts labels Feb 22, 2024
@emmamarichal emmamarichal linked an issue Feb 22, 2024 that may be closed by this pull request
@emmamarichal emmamarichal added the III Expand glyphset more features and more language coverage label Feb 22, 2024

This comment was marked as outdated.

@emmamarichal emmamarichal marked this pull request as ready for review February 22, 2024 13:12
@emmamarichal emmamarichal requested a review from m4rc1e February 22, 2024 13:13
Copy link

FontBakery report

fontbakery version: 0.12.0a2

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[2] Pacifico-Regular.ttf
🔥 FAIL: Ensure the font supports case swapping for all its glyphs. (com.google.fonts/check/case_mapping)
  • 🔥 FAIL The following glyphs lack their case-swapping counterparts:
Glyph present in the font Missing case-swapping counterpart
U+1E09: LATIN SMALL LETTER C WITH CEDILLA AND ACUTE U+1E08: LATIN CAPITAL LETTER C WITH CEDILLA AND ACUTE

[code: missing-case-counterparts]

INFO: METADATA.pb: Validate family.repository_url field. (com.google.fonts/check/metadata/minisite_url)
  • INFO Please ocnsider adding a family.minisite_url entry. [code: lacks-minisite-url]

All other checks

[20] Pacifico-Regular.ttf
🔥 FAIL: Shapes languages in all GF glyphsets. (com.google.fonts/check/glyphsets/shape_languages)
  • 🔥 FAIL GF_Latin_Core glyphset:
Language FAIL messages
nl_Latn (Dutch) Shaper didn't attach acutecomb to j.fina

[code: failed-language-shaping]

🔥 FAIL: Does DESCRIPTION file contain broken links? (com.google.fonts/check/description/broken_links)
  • 🔥 FAIL The following links are broken in the DESCRIPTION file:
    https://sansoxygen.com/ (status code: 406) [code: broken-links]
WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
  • WARN The following glyphs could not be reached by codepoint or substitution rules:

    • descendercombcy

    • hookcombcy

    • hookcombcy.case

    • uni004A0301

    • uni006A0301

    • uni0326.alt
      [code: unreachable-glyphs]

WARN: Check if each glyph has the recommended amount of contours. (com.google.fonts/check/contour_count)
  • WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are infered from the typical ammounts of contours observed in a large collection of reference font families. The divergences listed below may simply indicate a significantly different design on some of your glyphs. On the other hand, some of these may flag actual bugs in the font such as glyphs mapped to an incorrect codepoint. Please consider reviewing the design and codepoint assignment of these to make sure they are correct.

The following glyphs do not have the recommended number of contours:

- Glyph name: A	Contours detected: 1	Expected: 2

- Glyph name: B	Contours detected: 1	Expected: 2 or 3

- Glyph name: D	Contours detected: 1	Expected: 2

- Glyph name: G	Contours detected: 2	Expected: 1

- Glyph name: H	Contours detected: 2	Expected: 1

- Glyph name: J	Contours detected: 2	Expected: 1

- Glyph name: V	Contours detected: 2	Expected: 1

- Glyph name: Y	Contours detected: 2	Expected: 1

- Glyph name: b	Contours detected: 3	Expected: 2

- Glyph name: d	Contours detected: 3	Expected: 2

- 357 more.

Use -F or --full-lists to disable shortening of long lists.
[code: contour-count]

WARN: Do any segments have colinear vectors? (com.google.fonts/check/outline_colinear_vectors)
  • WARN The following glyphs have colinear vectors:

    • Oslash (U+00D8): L<<301.0,137.0>--<387.0,455.0>> -> L<<387.0,455.0>--<458.0,730.0>>

    • Oslash (U+00D8): L<<561.0,706.0>--<491.0,451.0>> -> L<<491.0,451.0>--<403.0,113.0>>

    • Oslashacute (U+01FE): L<<301.0,137.0>--<387.0,455.0>> -> L<<387.0,455.0>--<458.0,730.0>>

    • Oslashacute (U+01FE): L<<561.0,706.0>--<491.0,451.0>> -> L<<491.0,451.0>--<403.0,113.0>>

    • cent (U+00A2): L<<201.0,106.0>--<216.0,222.0>> -> L<<216.0,222.0>--<231.0,346.0>>

    • cent (U+00A2): L<<298.0,351.0>--<280.0,222.0>> -> L<<280.0,222.0>--<265.0,93.0>>

    • colonmonetary (U+20A1): L<<175.0,226.0>--<224.0,321.0>> -> L<<224.0,321.0>--<306.0,483.0>>

    • colonmonetary (U+20A1): L<<236.0,112.0>--<323.0,280.0>> -> L<<323.0,280.0>--<399.0,430.0>>

    • colonmonetary (U+20A1): L<<375.0,477.0>--<283.0,299.0>> -> L<<283.0,299.0>--<203.0,141.0>>

    • colonmonetary (U+20A1): L<<421.0,333.0>--<379.0,252.0>> -> L<<379.0,252.0>--<302.0,99.0>>

    • 15 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-colinear-vectors]

WARN: Do outlines contain any jaggy segments? (com.google.fonts/check/outline_jaggy_segments)
  • WARN The following glyphs have jaggy segments:

    • Eng (U+014A): B<<367.5,637.0>-<363.0,594.0>-<356.0,547.0>>/B<<356.0,547.0>-<406.0,693.0>-<482.5,770.5>> = 10.433431209596757

    • M (U+004D): B<<360.0,638.5>-<354.0,600.0>-<346.0,556.0>>/B<<346.0,556.0>-<387.0,673.0>-<433.5,736.5>> = 9.00701009558664

    • M (U+004D): B<<768.0,638.5>-<766.0,619.0>-<761.0,590.0>>/B<<761.0,590.0>-<796.0,686.0>-<838.0,742.5>> = 10.24860564909047

    • N (U+004E): B<<367.5,637.0>-<363.0,594.0>-<356.0,547.0>>/B<<356.0,547.0>-<406.0,693.0>-<482.5,770.5>> = 10.433431209596757

    • Nacute (U+0143): B<<367.5,637.0>-<363.0,594.0>-<356.0,547.0>>/B<<356.0,547.0>-<406.0,693.0>-<482.5,770.5>> = 10.433431209596757

    • Ncaron (U+0147): B<<367.5,637.0>-<363.0,594.0>-<356.0,547.0>>/B<<356.0,547.0>-<406.0,693.0>-<482.5,770.5>> = 10.433431209596757

    • Nmacronbelow (U+1E48): B<<367.5,637.0>-<363.0,594.0>-<356.0,547.0>>/B<<356.0,547.0>-<406.0,693.0>-<482.5,770.5>> = 10.433431209596757

    • Ntilde (U+00D1): B<<367.5,637.0>-<363.0,594.0>-<356.0,547.0>>/B<<356.0,547.0>-<406.0,693.0>-<482.5,770.5>> = 10.433431209596757

    • U (U+0055): B<<623.5,213.0>-<628.0,250.0>-<635.0,296.0>>/B<<635.0,296.0>-<586.0,151.0>-<509.5,73.0>> = 10.019165103714371

    • Uacute (U+00DA): B<<623.5,213.0>-<628.0,250.0>-<635.0,296.0>>/B<<635.0,296.0>-<586.0,151.0>-<509.5,73.0>> = 10.019165103714371

    • 164 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-jaggy-segments]

WARN: Do outlines contain any semi-vertical or semi-horizontal lines? (com.google.fonts/check/outline_semi_vertical)
  • WARN The following glyphs have semi-vertical/semi-horizontal lines:

    • Euro (U+20AC): L<<208.0,256.0>--<328.0,257.0>>

    • Euro (U+20AC): L<<223.0,361.0>--<340.0,362.0>>

    • Euro (U+20AC): L<<332.0,296.0>--<210.0,297.0>>

    • bracketleft (U+005B): L<<320.0,-94.0>--<166.0,-93.0>>

    • bracketright (U+005D): L<<142.0,930.0>--<296.0,929.0>>

    • lira (U+20A4): L<<216.0,256.0>--<337.0,257.0>>

    • lira (U+20A4): L<<225.0,361.0>--<349.0,362.0>>

    • lira (U+20A4): L<<328.0,191.0>--<211.0,192.0>>

    • lira (U+20A4): L<<341.0,296.0>--<219.0,297.0>>

    • sterling (U+00A3): L<<362.0,231.0>--<215.0,232.0>>

    • 19 more.

Use -F or --full-lists to disable shortening of long lists. [code: found-semi-vertical]

WARN: Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (com.google.fonts/check/soft_dotted)
  • WARN The dot of soft dotted characters used in orthographies must disappear in the following strings: і́

The dot of soft dotted characters should disappear in other cases, for example: ḭ̀ ḭ́ ḭ̂ ḭ̃ ḭ̄ ḭ̆ ḭ̇ ḭ̈ ḭ̉ ḭ̊ ḭ̋ ḭ̌ ḭ̏ ḭ̑ ḭ̒ і̀ і̂ і̃ і̄ і̆

Your font fully covers the following languages that require the soft-dotted feature: Belarusian (Cyrl, 10,064,517 speakers), Ukrainian (Cyrl, 29,273,587 speakers), Lithuanian (Latn, 2,357,094 speakers).

Your font does not cover the following languages that require the soft-dotted feature: Igbo (Latn, 27,823,640 speakers), Dutch (Latn, 31,709,104 speakers), Dan (Latn, 1,099,244 speakers), Koonzime (Latn, 40,000 speakers), Gulay (Latn, 250,478 speakers), Lugbara (Latn, 2,200,000 speakers), Kom (Latn, 360,685 speakers), South Central Banda (Latn, 244,000 speakers), Yala (Latn, 200,000 speakers), Cicipu (Latn, 44,000 speakers), Ngbaka (Latn, 1,020,000 speakers), Aghem (Latn, 38,843 speakers), Ebira (Latn, 2,200,000 speakers), Bete-Bendi (Latn, 100,000 speakers), Bafut (Latn, 158,146 speakers), Sar (Latn, 500,000 speakers), Mango (Latn, 77,000 speakers), Navajo (Latn, 166,319 speakers), Ma’di (Latn, 584,000 speakers), Nzakara (Latn, 50,000 speakers), Dii (Latn, 71,000 speakers), Kpelle, Guinea (Latn, 622,000 speakers), Southern Kisi (Latn, 360,000 speakers), Ejagham (Latn, 120,000 speakers), Mfumte (Latn, 79,000 speakers), Makaa (Latn, 221,000 speakers), Avokaya (Latn, 100,000 speakers), Fur (Latn, 1,230,163 speakers), Mundani (Latn, 34,000 speakers), Nateni (Latn, 100,000 speakers), Ijo, Southeast (Latn, 2,471,000 speakers), Zapotec (Latn, 490,000 speakers), Ekpeye (Latn, 226,000 speakers), Basaa (Latn, 332,940 speakers). [code: soft-dotted]

WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
  • WARN It seems that Raphael Alẹ́gbẹ́lẹ́yẹ̀ is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
  • WARN It seems that Botjo Nikoltchev is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
  • WARN It seems that Ani Petrova is still not listed on the designers catalog. Please submit a photo and a link to a webpage where people can learn more about the work of this designer/typefoundry. [code: profile-not-found]
WARN: Check for codepoints not covered by METADATA subsets. (com.google.fonts/check/metadata/unreachable_subsetting)
  • WARN The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+0020 SPACE: try adding one of: canadian-aboriginal, inscriptional-parthian, nag-mundari, tamil, manichaean, chinese-hongkong, glagolitic, phags-pa, arabic, ethiopic, mayan-numerals, palmyrene, adlam, gunjala-gondi, toto, kawi, khmer, chorasmian, mahajani, osage, soyombo, nabataean, kaithi, mende-kikakui, tagbanwa, old-hungarian, hebrew, grantha, dives-akuru, old-north-arabian, tifinagh, yi, cypriot, osmanya, ottoman-siyaq-numbers, meroitic, lycian, tirhuta, phoenician, chinese-traditional, coptic, yezidi, cypro-minoan, tibetan, kannada, sogdian, tai-le, devanagari, inscriptional-pahlavi, armenian, ugaritic, deseret, pau-cin-hau, miao, old-persian, khojki, linear-b, oriya, carian, kharoshthi, avestan, tangut, elbasan, kayah-li, syloti-nagri, sinhala, signwriting, old-italic, sharada, gothic, zanabazar-square, korean, hanifi-rohingya, old-sogdian, indic-siyaq-numbers, batak, limbu, music, old-permic, old-turkic, siddham, tagalog, telugu, elymaic, syriac, psalter-pahlavi, runic, greek, dogra, duployan, myanmar, sundanese, warang-citi, cuneiform, modi, old-south-arabian, cham, lao, symbols, masaram-gondi, nandinagari, tai-viet, mro, saurashtra, buginese, khudawadi, samaritan, sora-sompeng, thaana, bhaiksuki, ol-chiki, makasar, nushu, balinese, hanunoo, meroitic-hieroglyphs, braille, chinese-simplified, newa, rejang, anatolian-hieroglyphs, meroitic-cursive, lepcha, takri, wancho, gurmukhi, tamil-supplement, marchen, imperial-aramaic, shavian, chakma, multani, lisu, malayalam, buhid, egyptian-hieroglyphs, bassa-vah, tangsa, mongolian, vai, bengali, ahom, nko, medefaidrin, math, bamum, thai, new-tai-lue, tai-tham, brahmi, old-uyghur, meetei-mayek, caucasian-albanian, nyiakeng-puachue-hmong, lydian, hatran, javanese, japanese, ogham, mandaic, pahawh-hmong, vithkuqi, znamenny, georgian, cherokee, greek-ext, linear-a, khitan-small-script, gujarati

  • U+00A0 NO-BREAK SPACE: try adding one of: canadian-aboriginal, inscriptional-parthian, nag-mundari, tamil, manichaean, chinese-hongkong, glagolitic, phags-pa, arabic, ethiopic, mayan-numerals, palmyrene, adlam, gunjala-gondi, toto, kawi, khmer, chorasmian, mahajani, osage, soyombo, nabataean, kaithi, mende-kikakui, tagbanwa, old-hungarian, hebrew, grantha, dives-akuru, old-north-arabian, tifinagh, yi, cypriot, osmanya, ottoman-siyaq-numbers, meroitic, lycian, tirhuta, phoenician, chinese-traditional, coptic, yezidi, cypro-minoan, tibetan, kannada, sogdian, tai-le, devanagari, inscriptional-pahlavi, armenian, ugaritic, deseret, pau-cin-hau, miao, old-persian, khojki, linear-b, oriya, carian, kharoshthi, avestan, tangut, elbasan, kayah-li, syloti-nagri, sinhala, signwriting, old-italic, sharada, gothic, zanabazar-square, korean, hanifi-rohingya, old-sogdian, indic-siyaq-numbers, batak, limbu, music, old-permic, old-turkic, siddham, tagalog, telugu, elymaic, syriac, psalter-pahlavi, runic, greek, dogra, duployan, myanmar, sundanese, warang-citi, cuneiform, modi, old-south-arabian, cham, lao, symbols, masaram-gondi, nandinagari, tai-viet, mro, saurashtra, buginese, khudawadi, samaritan, sora-sompeng, thaana, bhaiksuki, ol-chiki, makasar, nushu, balinese, hanunoo, meroitic-hieroglyphs, braille, chinese-simplified, newa, rejang, anatolian-hieroglyphs, meroitic-cursive, lepcha, takri, wancho, gurmukhi, tamil-supplement, marchen, imperial-aramaic, shavian, chakma, multani, lisu, malayalam, buhid, egyptian-hieroglyphs, bassa-vah, tangsa, mongolian, vai, bengali, ahom, nko, medefaidrin, math, bamum, thai, new-tai-lue, tai-tham, brahmi, old-uyghur, meetei-mayek, caucasian-albanian, nyiakeng-puachue-hmong, lydian, hatran, javanese, japanese, ogham, mandaic, pahawh-hmong, vithkuqi, znamenny, georgian, cherokee, greek-ext, linear-a, khitan-small-script, gujarati

  • U+02C7 CARON: try adding one of: canadian-aboriginal, yi, tifinagh

  • U+02C9 MODIFIER LETTER MACRON: not included in any glyphset definition

  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi

  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi

  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi

  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition

  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: tifinagh, math, cherokee, coptic

  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
    50 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: cyrillic, cyrillic-ext, latin, latin-ext, menu, vietnamese [code: unreachable-subsetting]

WARN: Checking OS/2 achVendID. (com.google.fonts/check/vendor_id)
  • WARN OS/2 VendorID value 'newt' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx
    [code: unknown]
WARN: Is there kerning info for non-ligated sequences? (com.google.fonts/check/kerning_for_non_ligated_sequences)
  • WARN GPOS table lacks kerning info for the following non-ligated sequences:

    • f + f

    • f + i

    • i + i_j.loclNLD

    • i_j.loclNLD + j

    • j + l

    • lslash + lslash

    • t + t [code: lacks-kern-info]

WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
  • WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
  • INFO ofl/pacifico [code: family-path]
INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
  • INFO This font contains the following optional tables:

    • cvt

    • fpgm

    • loca

    • prep

    • GPOS

    • GSUB

    • gasp [code: optional-tables]

INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
INFO: EPAR table present in font? (com.google.fonts/check/epar)
INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
  • INFO Hinting filesize impact:
ofl/pacifico/Pacifico-Regular.ttf
Dehinted Size 537.2kb
Hinted Size 627.5kb
Increase 90.3kb
Change 16.8 %
[code: size-impact]
INFO: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
  • INFO These are the ppm ranges declared on the gasp table:

PPM <= 65535:
flag = 0x0F
- Use grid-fitting
- Use grayscale rendering
- Use gridfitting with ClearType symmetric smoothing
- Use smoothing along multiple axes with ClearType®
[code: ranges]

INFO: Familyname must be unique according to namecheck.fontdata.com (com.google.fonts/check/fontdata_namecheck)
  • INFO The family name "Pacifico" seems to be already in use.
    Please visit http://namecheck.fontdata.com for more info. [code: name-collision]

[1] Family checks
INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
  • INFO All of the fonts lack a STAT table.
    [code: summary]

Summary

💔 ERROR ☠ FATAL 🔥 FAIL ⚠ WARN 💤 SKIP ℹ INFO 🍞 PASS 🔎 DEBUG
0 0 3 11 59 9 175 0
0% 0% 1% 4% 23% 4% 68% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@m4rc1e
Copy link
Collaborator

m4rc1e commented Feb 22, 2024

It looks like the font has been rekerned.

Regular-diffbrowsers_text-macOS-12 7 3-x86_64-i386-64bit_firefox_122 0

The family has 300m requests a week so imo it should be fine. However, let's raise it.

@m4rc1e m4rc1e added the -- Needs manager's opinion from upper level label Feb 22, 2024
@emmamarichal
Copy link
Collaborator Author

@davelab6 @chrissimpkins any thoughts?

@emmamarichal emmamarichal mentioned this pull request Mar 28, 2024
@davelab6
Copy link
Member

I am discussing with @Fonthausen to get this fixed this year by him

@davelab6 davelab6 self-assigned this Apr 16, 2024
@davelab6 davelab6 added this to the 2024 Q2 milestone Apr 16, 2024
@davelab6 davelab6 removed the -- Needs manager's opinion from upper level label Apr 16, 2024
@vv-monsalve vv-monsalve added the -- Needs Upstream Resolution Upstream fix required before moving forward label Apr 16, 2024
@chrissimpkins
Copy link
Collaborator

Will wait on onboarding this project until Jacques is able to address the H spacing/kerning changes as indicated by Dave above.

@davelab6 davelab6 modified the milestones: 2024 Q2, 2024 Q4 Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-- Needs Upstream Resolution Upstream fix required before moving forward I Font Upgrade II African Mostly west african non-latin and African indigenous scripts III Expand glyphset more features and more language coverage
Projects
Status: PR GF
Development

Successfully merging this pull request may close these issues.

Update Pacifico
5 participants