-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "free" from font family descriptions #4444
base: main
Are you sure you want to change the base?
Conversation
The git diff isn't super clean due to this touching a lot of files that haven't been touched in many many years, so I'm going to follow up with a 2nd commit on this branch with minor fixes to make diffing cleaner. |
652086e
to
0259c82
Compare
OK this is now ready for review by internal stakeholders, I'll comment (or merge) when ready I've also just added a 2nd commit to add the relevant families
and then processed with
|
@RosaWagner do you think its good practice to add the |
@davelab6 i don’t think it is a good idea, we generate the lists with a script once a week to avoid conflict with the eng team, and the idea is to have this task automated thanks to the script, manual changes to the lists is messing up the checking workflow. If we all change the lists at the same time, we lose track of stuff, better to wait for one push to be finished before adding new stuff. If you add the PR to traffic Jam with the labels:
then you can generate the whole sandbox list with edit: also having changes to sandbox in each PR, will definitely create merge conflicts when one PR gets merged. Really advising against it. |
Update line breaks and make general copy fixes
6de0361
to
825e5c4
Compare
Rebased on main and took Dave's branch changes on all DESCRIPTION files, main side on all to_sandbox.txt files. There are no diffs in this branch on to_sandbox.txt now. Should be ready for review. cc @davelab6 |
@davelab6 Waiting on this OK from you to merge |
@davelab6 Are we ready to merge these changes? |
This is an urgent set of changes to family descriptions, requested by an internal stakeholder.
@RosaWagner this will require a large set of families to be added
to_sandbox.txt