-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsolata: Version 3.002 added #3760
base: main
Are you sure you want to change the base?
Conversation
Cancelled the CI on this one since it has a tonne of instances and will take forever. I'll run it locally. |
Updated Inconsolata: Version 3.002 added5445527: [gftools-packager] Inconsolata: Version 3.002 added
|
ef72a96
to
5445527
Compare
A few notes:
|
@aaronbell please cancel the github action each time you push a commit for this pr |
OK! I didn't realize I could :x |
What holds back this PR? |
@RosaWagner I'm currently working on the upstream. Will PR later on today. |
Ok cool! I cancelled the CI then ;) |
* Inconsolata Version 3.100 taken from the upstream repo https://github.com/googlefonts/Inconsolata at commit googlefonts/Inconsolata@fc1fc21.
Updated Inconsolata: Version 3.100 added2ae17fd: [gftools-packager] Inconsolata: Version 3.100 added
|
5194034
to
2ae17fd
Compare
Fontbakery reportFontbakery version: 0.8.8 [1] Family checksℹ INFO: Check axis ordering on the STAT table. (com.google.fonts/check/STAT/axis_order)
[24] Inconsolata[wdth,wght].ttf🔥 FAIL: Check glyphs do not have components which are themselves components. (com.google.fonts/check/glyf_nested_components)
Use -F or --full-lists to disable shortening of long lists. [code: found-nested-components] 🔥 FAIL: Font enables smart dropout control in "prep" table instructions? (com.google.fonts/check/smart_dropout)
🔥 FAIL: PPEM must be an integer on hinted fonts. (com.google.fonts/check/integer_ppem_if_hinted)
This can be accomplished by using the 'gftools fix-hinting' command. create virtualenvpython3 -m venv venv activate virtualenvsource venv/bin/activate install gftoolspip install git+https://www.github.com/googlefonts/tools [code: bad-flags] 🔥 FAIL: Ensure variable fonts include an avar table. (com.google.fonts/check/mandatory_avar_table)
⚠ WARN: Check copyright namerecords match license file. (com.google.fonts/check/name/license)
⚠ WARN: License URL matches License text on name table? (com.google.fonts/check/name/license_url)
⚠ WARN: Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (com.google.fonts/check/gasp)
PPM <= 8:
⚠ WARN: A static fonts directory with at least two fonts must accompany variable fonts (com.google.fonts/check/repo/vf_has_static_fonts)
⚠ WARN: METADATA.pb: Designers are listed correctly on the Google Fonts catalog? (com.google.fonts/check/metadata/designer_profiles)
⚠ WARN: Ensure Stylistic Sets have description. (com.google.fonts/check/stylisticset_description)
⚠ WARN: Ensure fonts have ScriptLangTags declared on the 'meta' table. (com.google.fonts/check/meta/script_lang_tags)
⚠ WARN: Font contains '.notdef' as its first glyph? (com.google.fonts/check/mandatory_glyphs)
⚠ WARN: Check font contains no unreachable glyphs (com.google.fonts/check/unreachable_glyphs)
⚠ WARN: Ensure dotted circle glyph is present and can attach marks. (com.google.fonts/check/dotted_circle)
⚠ WARN: Checking correctness of monospaced metadata. (com.google.fonts/check/monospace)
ℹ INFO: Does DESCRIPTION file contain a upstream Git repo URL? (com.google.fonts/check/description/git_url)
ℹ INFO: Show hinting filesize impact. (com.google.fonts/check/hinting_impact)
ℹ INFO: Font has old ttfautohint applied? (com.google.fonts/check/old_ttfautohint)
ℹ INFO: EPAR table present in font? (com.google.fonts/check/epar)
ℹ INFO: Familyname must be unique according to namecheck.fontdata.com (com.google.fonts/check/fontdata_namecheck)
ℹ INFO: Check for font-v versioning. (com.google.fonts/check/fontv)
ℹ INFO: Check samples can be rendered. (com.google.fonts/check/metadata/can_render_samples)
ℹ INFO: Font contains all required tables? (com.google.fonts/check/required_tables)
ℹ INFO: List all superfamily filepaths (com.google.fonts/check/superfamily/list)
Note: The following loglevels were omitted in this report:
|
What's the glyphsLib issue here? |
Just had another look. Compilation fails with
@simoncozens I'm guessing we've part implemented smart components? |
Smart components are fine, this is corner components. And fixing that up could be a good job for Georg. |
@m4rc1e the last version of builder should have fixed the issue with the reversed contours in manually hinted fonts. the config.yaml should contain:
|
I don't think we support corner components yet so we can't move this forward. |
No, we only support pretty basic corner components, not those where the part doesn't start on the axis. |
ef72a96: [gftools-packager] Inconsolata: Version 3.002 added