Send QUIT command when closing the connection without force: true. #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurdm
reviewed
Aug 3, 2021
| @@ -203,7 +203,7 @@ class RespClient { | |||
| Future<void> close({bool force = false}) async { | |||
| _closing = true; | |||
|
|
|||
| if (!_closing) { | |||
There was a problem hiding this comment.
How was this even supposed to work before?
There was a problem hiding this comment.
I think we have never sent the QUIT message.
There was a problem hiding this comment.
I think I googled it and figured closing the outgoing stream while continuing to read ought to be just as reasonable.
But I'm okay, sending QUIT, why not..
jonasfj
reviewed
Sep 21, 2021
| @@ -203,7 +203,7 @@ class RespClient { | |||
| Future<void> close({bool force = false}) async { | |||
| _closing = true; | |||
|
|
|||
| if (!_closing) { | |||
There was a problem hiding this comment.
I think I googled it and figured closing the outgoing stream while continuing to read ought to be just as reasonable.
But I'm okay, sending QUIT, why not..
| Future<void> close({bool force = false}) async { | ||
| _closing = true; | ||
|
|
||
| if (!_closing) { | ||
| if (!force) { | ||
| // Always send QUIT message to be nice | ||
| try { | ||
| final quit = command(['QUIT']); |
There was a problem hiding this comment.
This will throw if _closing = true I guess we need to set it later...
lhmzhou
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we set
_closing = truein the line above the if condition, I think the expression should depend on theforceparameter.