Introduce a cargo clippy run
#2025
Conversation
mgeisler
force-pushed
the
clippy-lint
branch
2 times, most recently
from
0590609 to
3917067
Compare
Personally, I don’t always agree with Clippy, but it a very widely recommended tool for writing idiomatic Rust. So on balance, I think it’s overall a good idea to enable it for both our exercises and our tooling.
| blood_pressure_change: match self.last_blood_pressure { | ||
| Some(lbp) => { | ||
| Some((bp.0 as i32 - lbp.0 as i32, bp.1 as i32 - lbp.1 as i32)) | ||
| } | ||
| None => None, | ||
| }, |
There was a problem hiding this comment.
We should probably exclude third_party/ somehow..
There was a problem hiding this comment.
Oh, good idea! Let me figure out how to do that before merging!
There was a problem hiding this comment.
If the settings are done in the workspace Cargo.toml and every Cargo.toml has a workspace = true in the [lints] section as described in https://doc.rust-lang.org/cargo/reference/workspaces.html#the-lints-table we could tell cargo clippy what to do in the third_party Cargo.toml.
This would enable a central configuration for clippy and gives the option to override specific settings for individual components
|
Another thought, as discussed on #2410. We should try and enable Clippy as part of |
This might help catch stylistic problems in our Rust code.