[Monitoring] Enrich UNTRIAGED_TESTCASE_AGE metric to track testcases stuck in analyze #4547
+49
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alhijazi
reviewed
Dec 23, 2024
| TESTCASE_UPLOAD_TRIAGE_DURATION = monitor.CumulativeDistributionMetric( | ||
| 'uploaded_testcase_analysis/triage_duration_secs', | ||
| TESTCASE_TRIAGE_DURATION = monitor.CumulativeDistributionMetric( | ||
| 'testcase_analysis/triage_duration_secs', |
There was a problem hiding this comment.
Let's rename this to triage_duration_hours (since the unit is hours)
alhijazi
approved these changes
Dec 23, 2024
jonathanmetzman
approved these changes
Dec 23, 2024
| # File the bug first and then create filed bug metadata. | ||
| if not _file_issue(testcase, issue_tracker, throttler): | ||
| _emit_untriaged_testcase_age_metric(testcase, PENDING_FILING) | ||
| _increment_untriaged_testcase_count(testcase.job_type, PENDING_FILING) |
There was a problem hiding this comment.
There's a lot of stuff we're doing here for metrics. Is any of it tracked in tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We currently have no way to tell if analyze task was successfully executed. The TESTCASE_UPLOAD_TRIAGE_DURATION metric from #4364 would only track duration for tasks that did finish.
An analyze_pending field is added to the Testcase entity in datastore, which is set to False by default, to True for manually uploaded testcases, and to False once analyze task postprocess runs.
It also increments the UNTRIAGED_TESTCASE_AGE metric from #4381 with a status label, so we can know at what step the testcase is stuck, thus allowing us to alert if analyze is taking longer to finish than expected.
The alert itself could be, for instance, P50 age of untriaged testcase (status=analyze_pending) > 3h.
Also, this retroactively addresses comments from #4481: