Refactor regression_task.found_regression_near_extreme_revisions.
#3927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alhijazi PTAL |
alhijazi
reviewed
Apr 9, 2024
alhijazi
approved these changes
Apr 10, 2024
|
@jonathanmetzman PTAL, this is a prereq for #3934 which aims to fix an issue where regression task can get stuck. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prework for changing the behavior of
check_earliest_revisions()to perform a binary search for the first good build instead of just checking the first few and erroring out if unsuccessful.See also https://crbug.com/333014970#comment2