Ensure preemptive hosts only run fuzz tasks for android #3808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverchang
reviewed
Mar 6, 2024
| @@ -159,6 +159,11 @@ def is_mte_build(): | |||
| return 'mte' in build_flavor | |||
|
|
|||
|
|
|||
| def using_preemptible_host(): | |||
| """Return True if using a peemptible host.""" | |||
| return '-pre-' in environment.get_value('DOCKER_HOST', '') | |||
There was a problem hiding this comment.
See my question on the other internal CL :)
I would've expected the hostname to propagate to inside the container, as that's what we expect in our other environments.
DOCKER_HOST also seems like it's leaking abstraction a bit (the fact that this is running in a docker container). Perhaps we could just call this HOSTNAME if we do end up needing an env var?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.