Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added integration test for virtual method inheritance #777

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

johnperry-math
Copy link

Adds an integration test to address Issue #774

@adetaylor
Copy link
Collaborator

@johnperry-math I'd like to land this test now with an extra attribute:

#[ignore] // https://github.com/google/autocxx/issues/774

to avoid future merge conflicts, like the one which just occurred. Please could you update the PR to add that?

@johnperry-math
Copy link
Author

Sorry it took so long. I believe I have made the change successfully and redid the pull request. I didn't mean to wait so long; again, sorry about that.

@adetaylor
Copy link
Collaborator

Thanks, but I fear you added the attribute to the wrong test!

@johnperry-math
Copy link
Author

I'm so sorry. I dawdled so long that I had to spend a lot of time merging to reconcile our branches (e.g., the old tests.rs was gone) so I just searched on test_virtual and it didn't occur to me that there might be more than 1 function that started with that phrase. I've fixed it now (I even compared commands with the original issue to be sure).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants