-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRUD operation screen in the demo app. #2746
base: master
Are you sure you want to change the base?
Conversation
Screen.Recording.2024-11-28.at.10.47.17.PM.mov |
demo/src/main/java/com/google/android/fhir/demo/CrudOperationFragment.kt
Outdated
Show resolved
Hide resolved
Screen.Recording.2024-12-19.at.3.52.00.PM.mov |
Thanks @santosh-pingle for this! A few comments:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Can you make sure the crud screen are scrollable. Seems like you need to press back to be able to submit the changes. Ideal way would be to scroll to bottom and press submit.
Yes, the screen is scrollable. You can scroll down and click the submit button. (though its not captured in the video.) |
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2694
Description
Clear and concise code change description.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Feature
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.