Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRUD operation screen in the demo app. #2746

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

santosh-pingle
Copy link
Collaborator

@santosh-pingle santosh-pingle commented Nov 28, 2024

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2694

Description
Clear and concise code change description.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Feature

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@santosh-pingle
Copy link
Collaborator Author

Screen.Recording.2024-11-28.at.10.47.17.PM.mov

@santosh-pingle santosh-pingle marked this pull request as ready for review November 29, 2024 05:58
@santosh-pingle santosh-pingle requested a review from a team as a code owner November 29, 2024 05:58
@santosh-pingle
Copy link
Collaborator Author

Screen.Recording.2024-12-19.at.3.52.00.PM.mov

@jingtang10
Copy link
Collaborator

Thanks @santosh-pingle for this!

A few comments:

  • when you swithc back to read it and click the button again at 1:01 the gender is not populated
  • can you pls change the button text to create/read/update/delete? it seems a bit more natural that way
  • can you double check what happens when you try to create twice, or try to delete twice, or try to update before create? are there error messages?

Copy link
Collaborator

@MJ1998 MJ1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Can you make sure the crud screen are scrollable. Seems like you need to press back to be able to submit the changes. Ideal way would be to scroll to bottom and press submit.

@santosh-pingle
Copy link
Collaborator Author

Nit: Can you make sure the crud screen are scrollable. Seems like you need to press back to be able to submit the changes. Ideal way would be to scroll to bottom and press submit.

Yes, the screen is scrollable. You can scroll down and click the submit button. (though its not captured in the video.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the FHIR Engine demo app to showcase the APIs
4 participants