Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable new lines for single line edit text #2737

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rahulmalhotra
Copy link
Member

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1637

Description
This change adds android:inputType="text" for single line edit text which won't allow new lines to be added for this field as we've already specified android:maxLines="1"

Alternative(s) considered
N/A

Type
Bug fix

Screenshots (if applicable)
N/A

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@rahulmalhotra rahulmalhotra requested a review from a team as a code owner November 25, 2024 12:04
Copy link
Collaborator

@santosh-pingle santosh-pingle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!, it looks good.
@jingtang10 please have look.

Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Rahul! This change is good. Approving.

Just one quick question - do you need to add this to multi line widget too?

@rahulmalhotra
Copy link
Member Author

Hi @jingtang10 we don't need to add it to multi line solve this issue. Though we can add android:inputType="textMultiLine" along with android:maxLines that we want to be visible for our multi-line edit text. Let me know the preferred value for it and if I should update it with this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"String" type item allows entry of new lines, but UI does not handle them
3 participants