Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight form fields that fail validation when submit button is clicked #2722

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rahulmalhotra
Copy link
Member

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2681

Description
This change removes forceValidation = false assignment in the QuestionnaireViewModel which was re-rendering the current patient edit screen without validation results.

Alternative(s) considered
N/A

Type
Bug fix

Screenshots (if applicable)
N/A

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@rahulmalhotra rahulmalhotra requested a review from a team as a code owner November 14, 2024 14:32
@rahulmalhotra rahulmalhotra marked this pull request as draft November 25, 2024 12:04
@rahulmalhotra rahulmalhotra self-assigned this Jan 13, 2025
@rahulmalhotra rahulmalhotra force-pushed the rm/highlight-validated-fields branch 2 times, most recently from 662ca2d to 7b3e378 Compare January 13, 2025 09:59
@rahulmalhotra rahulmalhotra force-pushed the rm/highlight-validated-fields branch from 7b3e378 to 7f23c6e Compare January 13, 2025 10:02
@rahulmalhotra
Copy link
Member Author

Hi @jingtang10 as per our discussion, I removed forceValidation attribute and used modifiedQuestionnaireResponseItemSet instead. Please take a look and let me know if this looks good? I tested it locally by running the demo app and it's working fine.

@rahulmalhotra rahulmalhotra marked this pull request as ready for review January 13, 2025 10:24
@rahulmalhotra
Copy link
Member Author

Hi @jingtang10 I checked for the next/previous case. It depends on entry mode of questionnaire. Please take a look at my findings below:

  1. If the questionnaire has multiple pages, as we click the Next button, its going to validate the fields on the current page only if the questionnaire as an entry mode of prior-edit or sequential code ref
  2. If there is no entry mode defined in the questionnaire, the default entry mode will be random and in this case, no validation error will throw on clicking the next button. However, as we submit the form at the last page, the popup will appear showing list of required fields which are not filled (even if those are on the previous page).

Please let me know how should we proceed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Form fields that fail validation are not highlighted when submit button is clicked
1 participant