Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed consuming answer of other component as a minValue for date picker #2682

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aurangzaibumer
Copy link
Collaborator

@aurangzaibumer aurangzaibumer commented Oct 1, 2024

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #[issue number]

Issue
Screen_recording_20240916_144502.webm

Description
we are setting the min date of a date field to the a value of another date field set early on the same form but it was not reflecting it. Since the ViewModel was sending the updated items but The Adapter was not updating it because the callback AreTheContentSame was returning true because we are not comparing olditem.minValueAnswer with newItem.minValueAnswer.

Type
Bug fix

Screenshots (if applicable)

3233_final.mp4

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

Copy link
Collaborator

@FikriMilano FikriMilano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aurangzaibumer, could you:

  1. Write some unit test for this change?
  2. Share recordings of before and after the change (so it's clear on what the bug is and how the fix perform)
  3. Create a ticket to explain the bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: PR under Review
Development

Successfully merging this pull request may close these issues.

2 participants