Suspend functions to evaluate fhirpath expressions #2678
Conversation
There was a problem hiding this comment.
Actually what I notice is that these "non-suspend" functions are being invoked from suspend functions only.
So instead of making each function suspend what if we make the source of flow to run on default dispatcher ? In class QuestionnaireViewModel, we could add flowOn operator to the questionnaireStateFlow
Okay, cool. I can try it out, not sure how we will handle passing testDispatcher for tests though. That is, in the QuestionnaireViewModelTest |
LZRS
force-pushed
the
2677-suspend-fhirpathengine
branch
from
5ed5f95 to
eb755f9
Compare
for page items to be validated. Previous 'currentPageItems' variable would get mutated multiple times within `getQuestionnaireAdapterItems` when evaluating nested questionnaire items
|
Also to fix #2646 (comment) |
LZRS
force-pushed
the
2677-suspend-fhirpathengine
branch
from
68f672b to
f369d51
Compare
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireViewModel.kt
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireViewModel.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireViewModel.kt
Outdated
Show resolved
Hide resolved
LZRS
force-pushed
the
2677-suspend-fhirpathengine
branch
from
393ad27 to
f369d51
Compare
FORK
- With unmerged PR #9
- WUP #13
SDK
- WUP google#2178
- WUP google#2650
- WUP google#2645
- WUP google#2678
- WUP google#2755
getting rid of dependecny on `forceValidation` toggle variable and instead add all current page items to the modifiedQuestionnaireResponseItemSet
LZRS
force-pushed
the
2677-suspend-fhirpathengine
branch
from
3347ee3 to
7d105ba
Compare
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2677
Description
Clear and concise code change description.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.