Handle different CSV file encodings #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this app handles only
UTF-8encoded CSV files, which is fine in many cases.This change allows to gracefully handle different CSV file encodings in a way that even when you have multiple different files with different encoding it will work well. I added only few most popular, as well some verbose message so any new person can easily add theirs as needed. Another way would be to use some library like
chardetin Python and detect file encoding but it is not very fast for bigger files.I stumbled upon this when working with multiple CSV files on MacOS that are MacRoman encoded (especially if you export CSV from some online spreadsheet tools.