require at least one argument for vararg #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In its current state,
generateContent(),generateContentStream()andcountTokens()let developers pass zero arguments, which then causes the runtime error:com.google.ai.client.generativeai.type.ServerException: * GenerateContentRequest.contents: contents is not specified- becausecontentsis a required field on the API.Although the current error might be helpful, it would be nice if a developer could spot this mistake in compile time rather than in runtime.
Backwards compatibility
The changes in this PR would probably not break most of the cases that we have documented (eg.
countTokens(content)), but would certainly break a few cases like for example if the developer was doing something likecountTokens(*contentArray, content)(which we actually document here).