Add options to enable or disable installation of mujoco samples and simulate #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Silvio! Let's have a non-empty PR description please 🙂 |
My bad! I forgot to carry over the description from #1477 , the problem should be fixed now. |
|
Thanks! @nimrod-gileadi will take a closer look next week. My cmake is rather weak... |
|
I am reviewing some old PR, if on this one there is any change required on my side feel free to ask @nimrod-gileadi @yuvaltassa, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logic uses regular CMake variables, that create confusing behavior when a CMake cache variable with the same name is set from the command line. The PR does not change the behaviour of the build system, but permits to users to enable installation of simulate and samples executables from the CMake options, as long as they also set
MUJOCO_ENABLE_RPATHtoOFF.