Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gpt4o and gpt-4o-mini support #10

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Isydmr
Copy link

@Isydmr Isydmr commented Aug 10, 2024

This PR adds support for the GPT-4o and GPT-4o-mini models, updates configurations, and upgrades the langfun and pyglove dependencies.

Copy link

google-cla bot commented Aug 10, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Isydmr
Copy link
Author

Isydmr commented Aug 23, 2024

@JerryWeiAI Could you please take a moment to review this PR when you get a chance?

@JerryWeiAI
Copy link
Contributor

Thanks for adding GPT-4o support! These changes look good to me.

@JerryWeiAI
Copy link
Contributor

@chengrunyang PTAL and merge if it looks good to you?

common/README.md Outdated Show resolved Hide resolved
eval/safe/config.py Outdated Show resolved Hide resolved
@@ -2,7 +2,7 @@ absl-py==2.1.0
aiohttp==3.9.3
aiosignal==1.3.1
annotated-types==0.6.0
anthropic==0.16.0
anthropic==0.33.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been verified (and same below)?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you asking for a clean environment installation with all dependencies or a re-run with Claude models?

Copy link
Author

@Isydmr Isydmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reviewing, @chengrunyang, left one comment 👍

common/README.md Outdated Show resolved Hide resolved
common/modeling.py Show resolved Hide resolved
common/shared_config.py Outdated Show resolved Hide resolved
eval/safe/config.py Outdated Show resolved Hide resolved
@@ -2,7 +2,7 @@ absl-py==2.1.0
aiohttp==3.9.3
aiosignal==1.3.1
annotated-types==0.6.0
anthropic==0.16.0
anthropic==0.33.0
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you asking for a clean environment installation with all dependencies or a re-run with Claude models?

@Isydmr Isydmr requested a review from chengrunyang September 9, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants