-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gpt4o and gpt-4o-mini support #10
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@JerryWeiAI Could you please take a moment to review this PR when you get a chance? |
Thanks for adding GPT-4o support! These changes look good to me. |
@chengrunyang PTAL and merge if it looks good to you? |
@@ -2,7 +2,7 @@ absl-py==2.1.0 | |||
aiohttp==3.9.3 | |||
aiosignal==1.3.1 | |||
annotated-types==0.6.0 | |||
anthropic==0.16.0 | |||
anthropic==0.33.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has this been verified (and same below)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you asking for a clean environment installation with all dependencies or a re-run with Claude models?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for reviewing, @chengrunyang, left one comment 👍
@@ -2,7 +2,7 @@ absl-py==2.1.0 | |||
aiohttp==3.9.3 | |||
aiosignal==1.3.1 | |||
annotated-types==0.6.0 | |||
anthropic==0.16.0 | |||
anthropic==0.33.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you asking for a clean environment installation with all dependencies or a re-run with Claude models?
This PR adds support for the
GPT-4o
andGPT-4o-mini
models, updates configurations, and upgrades the langfun and pyglove dependencies.