-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile refinements and add Apptainer definition #139
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
||
WORKDIR /app/alphafold | ||
|
||
CMD ["python3", "run_alphafold.py", "--help"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally this would be split into a separate ENTRYPOINT
and CMD
sections, e.g.
ENTRYPOINT ["python3", "run_alphafold.py"]
CMD ["--help"]
It would then be possible to pass the arguments directly to the Docker command, e.g.
docker run -it alphafold3 --output_dir=/root/af_output
However, this would involve rewriting the documentation and is arguably less intuitive so I'm broadly replicating the current functionality.
|
||
# Add the AlphaFold 3 source code from GitHub to the image and | ||
# set the working directory to there | ||
ADD https://github.com/google-deepmind/alphafold3.git#v${ALPHAFOLD_VERSION} /app/alphafold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This takes a different approach to the existing Dockerfile (which copies the contents from the local repository) and instead allows the Docker build to act as a stand-alone process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Brief overview of PR changes
Dockerfile:
apt
(primarily designed for interactive use) withapt-get
Apptainer definition file:
Issues:
triton
dependency is only available as compiled x86_64 wheel on pypi.org so ARM-based builds aren't currently possible without moving the triton install into a separate compile step.