feat: add junit-xml-extended format #4918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
enhancement
bombsimon
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Is the plan to use this extended version for anything that extends the junit-xml or would we have to create yet another format if there are other fields that might be conditional? If the latter it doesn't sound like it scales well but otoh we don't seem to extend the format very often so maybe not worth worrying about.
|
This format will be used for everything that deviates from the "basic" JUnit format. |
Antonboom
approved these changes
Aug 25, 2024
ldez
force-pushed
the
feat/extended-junit-xml
branch
from
977b49c
to
e5a80c8
Compare
ldez
changed the title
ldez
removed
the
blocked: until next minor
uudashr
pushed a commit
to uudashr/golangci-lint
that referenced
this pull request
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4900