Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: validate sarif output with json schema #4875

Closed
wants to merge 1 commit into from

Conversation

Zxilly
Copy link
Contributor

@Zxilly Zxilly commented Jul 21, 2024

No description provided.

@ldez ldez added the declined label Jul 21, 2024
@ldez
Copy link
Member

ldez commented Jul 21, 2024

#4831 (comment)

@ldez ldez closed this Jul 21, 2024
@Zxilly
Copy link
Contributor Author

Zxilly commented Jul 21, 2024

Obviously we still have work to do on the SARIF format, and this kind of detection ensures that the sarifs we generate are always valid. We can avoid the problem that we have generated a valid json, but not a valid sarif.

@ldez
Copy link
Member

ldez commented Jul 21, 2024

Obviously we still have work to do on the SARIF format

I don't share your opinion.

this kind of detection ensures that the sarifs we generate are always valid. We can avoid the problem that we have generated a valid json, but not a valid sarif.

This kind of detection will do nothing more than a simple test.
To be detected a problem should exist inside a test case.
However a problem doesn't exist by itself, it requires a specific test case, so the problem will never be detected by the validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants