Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add an anchor on every linter #4842

Closed
wants to merge 1 commit into from
Closed

docs: add an anchor on every linter #4842

wants to merge 1 commit into from

Conversation

ccoVeille
Copy link
Contributor

This will help to link linters without settings

Fixes #4841

This will help to link linters without settings

Fixes #4841
@ccoVeille
Copy link
Contributor Author

ccoVeille commented Jun 24, 2024

This implementation is VERY NAIVE and should be considered as Proof of Concept.

It's likely to be incomplete and would request to review and iterate.

For example:

  • the anchor icon is missing also is the css. I tried but I failed to find how. I'm backend after all 😅
  • having some link that point to the linter settings and some other to the linter description seems a bad idea.

@ldez
Copy link
Member

ldez commented Jun 24, 2024

This approach cannot work because it will create duplicate IDs, so the links on linters with settings will not work.

I created a PR with a working approach: #4843

@ldez ldez closed this Jun 24, 2024
@ldez ldez added the declined label Jun 24, 2024
@ccoVeille ccoVeille deleted the doc-add-anchor branch June 24, 2024 21:48
@ccoVeille
Copy link
Contributor Author

This approach cannot work because it will create duplicate IDs, so the links on linters with settings will not work.

I created a PR with a working approach: #4843

I don't think my code was creating duplicate it, but never mind I'm glad you opened something better than my PR to fix the issue I reported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: add a way to link linter without settings on the linter page
2 participants