Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: enable errorlint linter #4292

Merged
merged 1 commit into from
Jan 2, 2024
Merged

dev: enable errorlint linter #4292

merged 1 commit into from
Jan 2, 2024

Conversation

alexandear
Copy link
Member

This PR enables errorlint linter in .golangci.yml and fixes up issues:

non-wrapping format verb for fmt.Errorf. Use `%w` to format errors
comparing with == will fail on wrapped errors. Use errors.Is to check for a specific error

@ldez ldez added the topic: cleanup Related to code, process, or doc cleanup label Dec 30, 2023
@ldez ldez merged commit 85fb5a2 into golangci:master Jan 2, 2024
12 checks passed
@alexandear alexandear deleted the dev-enable-errorlint branch January 2, 2024 16:17
Antonboom pushed a commit to Antonboom/golangci-lint that referenced this pull request Mar 3, 2024
@alexandear @Antonboom
dev: enable errorlint linter (golangci#4292)
61d9172
@ldez ldez modified the milestone: v1.56 Mar 4, 2024
@alexandear alexandear mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
topic: cleanup Related to code, process, or doc cleanup
Projects
None yet
Milestone
v1.56
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandear @ldez