Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sloglint: add static-msg option #4213

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Conversation

mattdowdell
Copy link
Contributor

sloglint v0.3.0 was updated in #4183, but missed the new static-msg option. This adds support for that option to golangci-lint.

sloglint v0.3.0 was updated in #4183, but missed the new static-msg option. This adds support for that option to golangci-lint.
Copy link

boring-cyborg bot commented Nov 20, 2023

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Nov 20, 2023

CLA assistant check
All committers have signed the CLA.

@ldez ldez changed the title Add static-msg option for sloglint sloglint: add static-msg option Nov 20, 2023
@ldez ldez added the linter: update Update the linter implementation inside golangci-lint label Nov 20, 2023
@ldez ldez self-requested a review November 20, 2023 11:58
@ldez
Copy link
Member

ldez commented Nov 20, 2023

Hello @mattdowdell,
can you sign the CLA?
Why your PR is in draft mode?

@ldez ldez added the feedback required Requires additional feedback label Nov 20, 2023
@mattdowdell
Copy link
Contributor Author

@ldez I left it in draft while I get approval to sign the CLA. Given how innocuous the change is, I'm hoping that won't take long.

@ldez
Copy link
Member

ldez commented Nov 28, 2023

@mattdowdell any news?

@mattdowdell
Copy link
Contributor Author

One of my colleagues from legal reached out to check the diff size (28 lines) and if there was any IP within that, but unfortunately no approval as of yet.

@mattdowdell mattdowdell marked this pull request as ready for review November 29, 2023 08:05
@mattdowdell
Copy link
Contributor Author

@ldez CLA signed

@ldez ldez added enhancement New feature or improvement and removed feedback required Requires additional feedback labels Nov 29, 2023
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit f269abe into golangci:master Nov 29, 2023
12 checks passed
Antonboom pushed a commit to Antonboom/golangci-lint that referenced this pull request Mar 3, 2024
@ldez ldez modified the milestone: v1.56 Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement linter: update Update the linter implementation inside golangci-lint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants