Add gofactory linter

.golangci.reference.yml

@@ -686,6 +686,15 @@ linters-settings:
  - OPTIMIZE # marks code that should be optimized before merging
  - HACK # marks hack-around that should be removed before merging
 
+ gofactory:
+ # List of glob packages, which can create structures without factories inside the glob package.
+ # Default: []
+ packageGlobs:
+ - github.com/author/repository/path/to/package/**
+ # Use a factory to initiate a structure for glob packages only.
+ # Default: false
+ packageGlobsOnly: true
+
  gofmt:
  # Simplify code: gofmt with `-s` option.
  # Default: true
@@ -2410,6 +2419,7 @@ linters:
  - godot
  - godox
  - goerr113
+ - gofactory
  - gofmt
  - gofumpt
  - goheader
@@ -2531,6 +2541,7 @@ linters:
  - godot
  - godox
  - goerr113
+ - gofactory
  - gofmt
  - gofumpt
  - goheader

go.mod

@@ -69,6 +69,7 @@ require (
  github.com/leonklingele/grouper v1.1.1
  github.com/lufeee/execinquery v1.2.1
  github.com/macabu/inamedparam v0.1.3
+ github.com/maranqz/gofactory v1.0.0-rc1
  github.com/maratori/testableexamples v1.0.0
  github.com/maratori/testpackage v1.1.1
  github.com/matoous/godox v0.0.0-20230222163458-006bad1f9d26

pkg/config/linters_settings.go

@@ -204,6 +204,7 @@ type LintersSettings struct {
  Gocyclo GoCycloSettings
  Godot GodotSettings
  Godox GodoxSettings
+ Gofactory GoFactorySettings
  Gofmt GoFmtSettings
  Gofumpt GofumptSettings
  Goheader GoHeaderSettings
@@ -486,6 +487,11 @@ type GodoxSettings struct {
  Keywords []string
 }
 
+type GoFactorySettings struct {
+ PackageGlobs []string `mapstructure:"packageGlobs"`
+ PackageGlobsOnly bool `mapstructure:"packageGlobsOnly"`
+}
+
 type GoFmtSettings struct {
  Simplify bool
  RewriteRules []GoFmtRewriteRule `mapstructure:"rewrite-rules"`

pkg/golinters/gofactory.go

@@ -0,0 +1,30 @@
+package golinters
+
+import (
+ "github.com/maranqz/gofactory"
+ "golang.org/x/tools/go/analysis"
+
+ "github.com/golangci/golangci-lint/pkg/config"
+ "github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
+)
+
+func NewGoFactory(settings *config.GoFactorySettings) *goanalysis.Linter {
+ analyzer := gofactory.NewAnalyzer()
+
+ cfg := make(map[string]map[string]any)
+ if settings != nil {
+ cfg[analyzer.Name] = map[string]any{}
+
+ if len(settings.PackageGlobs) > 0 {
+ cfg[analyzer.Name]["packageGlobs"] = settings.PackageGlobs
+ cfg[analyzer.Name]["packageGlobsOnly"] = settings.PackageGlobsOnly
+ }
+ }
+
+ return goanalysis.NewLinter(
+ analyzer.Name,
+ analyzer.Doc,
+ []*analysis.Analyzer{analyzer},
+ cfg,
+ ).WithLoadMode(goanalysis.LoadModeTypesInfo)
+}

pkg/lint/lintersdb/manager.go

@@ -90,6 +90,7 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
  gocycloCfg *config.GoCycloSettings
  godotCfg *config.GodotSettings
  godoxCfg *config.GodoxSettings
+ goFactoryCfg *config.GoFactorySettings
  gofmtCfg *config.GoFmtSettings
  gofumptCfg *config.GofumptSettings
  goheaderCfg *config.GoHeaderSettings
@@ -176,6 +177,7 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
  gocycloCfg = &m.cfg.LintersSettings.Gocyclo
  godotCfg = &m.cfg.LintersSettings.Godot
  godoxCfg = &m.cfg.LintersSettings.Godox
+ goFactoryCfg = &m.cfg.LintersSettings.Gofactory
  gofmtCfg = &m.cfg.LintersSettings.Gofmt
  gofumptCfg = &m.cfg.LintersSettings.Gofumpt
  goheaderCfg = &m.cfg.LintersSettings.Goheader
@@ -492,6 +494,12 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
  WithLoadForGoAnalysis().
  WithURL("https://github.com/Djarvur/go-err113"),
 
+ linter.NewConfig(golinters.NewGoFactory(goFactoryCfg)).
+ WithSince("1.56.0").
+ WithPresets(linter.PresetStyle).
+ WithLoadForGoAnalysis().
+ WithURL("https://github.com/maranqz/gofactory"),
+
  linter.NewConfig(golinters.NewGofmt(gofmtCfg)).
  WithSince("v1.0.0").
  WithPresets(linter.PresetFormatting).

test/run_test.go

@@ -137,7 +137,7 @@ func TestCgoOk(t *testing.T) {
  "--timeout=3m",
  "--enable-all",
  "-D",
- "nosnakecase,gci",
+ "nosnakecase,gci,gofactory",
  ).
  WithTargetPath(testdataDir, "cgo").
  Runner().
@@ -355,7 +355,6 @@ func TestLineDirectiveProcessedFiles(t *testing.T) {
 func TestUnsafeOk(t *testing.T) {
  testshared.NewRunnerBuilder(t).
  WithNoConfig().
- WithArgs("--enable-all").
  WithTargetPath(testdataDir, "unsafe").
  Runner().
  Install().

test/testdata/configs/go_factory_package_globs_only.yml

@@ -0,0 +1,5 @@
+linters-settings:
+ gofactory:
+ packageGlobs:
+ - net/url/**
+ packageGlobsOnly: true

test/testdata/gofactory.go

@@ -0,0 +1,32 @@
+//golangcitest:args -Egofactory
+package testdata
+
+import (
+ "net/http"
+ alias_blocked "net/http"
+)
+
+type Struct struct{}
+
+var (
+ defaultGlobalRequest = http.Request{} // want `Use factory for http.Request`
+ defaultGlobalRequestPtr = &http.Request{} // want `Use factory for http.Request`
+)
+
+func Default() {
+ _ = http.Request{} // want `Use factory for http.Request`
+ _ = &http.Request{} // want `Use factory for http.Request`
+
+ _ = []http.Request{{}, http.Request{}} // want `Use factory for http.Request`
+ _ = []*http.Request{{}, &http.Request{}} // want `Use factory for http.Request`
+
+ call(http.Request{}) // want `Use factory for http.Request`
+
+ _ = []Struct{{}, {}}
+}
+
+func call(_ http.Request) {}
+
+func alias() {
+ _ = alias_blocked.Request{} // want `Use factory for http.Request`
+}

test/testdata/gofactory_package_globs_only.go

@@ -0,0 +1,46 @@
+//golangcitest:args -Egofactory
+//golangcitest:config_path configs/go_factory_package_globs_only.yml
+package testdata
+
+import (
+ "net/http"
+ neturl "net/url"
+)
+
+var (
+ nestedGlobalRequest = http.Request{}
+ nestedGlobalRequestPtr = &http.Request{}
+
+ blockedGlobalURL = neturl.URL{} // want `Use factory for url.URL`
+ blockedGlobalURLPtr = &neturl.URL{} // want `Use factory for url.URL`
+)
+
+func Blocked() {
+ _ = http.Request{}
+ _ = &http.Request{}
+
+ _ = neturl.URL{} // want `Use factory for url.URL`
+ _ = &neturl.URL{} // want `Use factory for url.URL`
+}
+
+type URL struct {
+ Scheme string
+ Opaque string
+ User *neturl.Userinfo
+ Host string
+ Path string
+ RawPath string
+ OmitHost bool
+ ForceQuery bool
+ RawQuery string
+ Fragment string
+ RawFragment string
+}
+
+func Casting() {
+ _ = neturl.URL(URL{}) // want `Use factory for url.URL`
+
+ uPtr, _ := neturl.Parse("")
+ u := *uPtr
+ _ = URL(u)
+}