Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trim Go version #3995

Merged
merged 1 commit into from
Aug 9, 2023
Merged

fix: trim Go version #3995

merged 1 commit into from
Aug 9, 2023

Conversation

ldez
Copy link
Member

@ldez ldez commented Aug 9, 2023

Trims the Go version to keep only M.m.

Since Go 1.21 the version inside the go.mod can be a patched version (ex: 1.21.0).
https://go.dev/doc/toolchain#versions

This a problem with staticcheck and gocritic.

dominikh/go-tools#1431

Related to #3933

@ldez ldez added bug Something isn't working area: config Related to .golangci.yml and/or cli options labels Aug 9, 2023
Copy link
Member

@ryancurrah ryancurrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit c1d8c56 into golangci:master Aug 9, 2023
14 checks passed
@ldez ldez deleted the fix/go-version branch August 9, 2023 11:43
@ldez ldez mentioned this pull request Jan 14, 2024
@ldez ldez added this to the v1.54 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: config Related to .golangci.yml and/or cli options bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants