Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for the new ginkgolinter's configuration #3970

Merged
merged 1 commit into from
Jul 23, 2023
Merged

Add tests for the new ginkgolinter's configuration #3970

merged 1 commit into from
Jul 23, 2023

Conversation

nunnatsa
Copy link
Contributor

PR #3962 added the new suppress-focus-container configuration for ginkgolinter.

This PR adds some tests to check the new configuration.

/cc @ldez

@ldez ldez added enhancement New feature or improvement area: tests Continuous integration, tests and other checks linter: update Update the linter implementation inside golangci-lint labels Jul 23, 2023
ldez
ldez approved these changes Jul 23, 2023
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't really need test cases for every option of a linter: the tests inside your linter repository are enough.
I never refuse tests 😄

@ldez ldez merged commit 0b62feb into golangci:master Jul 23, 2023
@nunnatsa nunnatsa deleted the ginkgolinter-tests branch July 24, 2023 04:52
@ldez ldez added this to the v1.54 milestone Mar 6, 2024
@alexandear alexandear mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area: tests Continuous integration, tests and other checks enhancement New feature or improvement linter: update Update the linter implementation inside golangci-lint
Projects
None yet
Milestone
v1.54
Development

Successfully merging this pull request may close these issues.
2 participants
@nunnatsa @ldez