Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: simplify issues and enabled set tests #3832

Merged
merged 1 commit into from
May 31, 2023
Merged

dev: simplify issues and enabled set tests #3832

merged 1 commit into from
May 31, 2023

Conversation

alexandear
Copy link
Member

This PR refactors tests:

  • replace raw loops with assert.Contains and assert.NotContains;
  • use assert.ElementsMatch instead of sort.Stirngs with assert.Equal.

@alexandear alexandear added the topic: cosmetic changes contain cosmetic improvements label May 12, 2023
ldez
ldez approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 0520232 into golangci:master May 31, 2023
@alexandear alexandear deleted the dev-refactor-issues-test branch May 31, 2023 20:49
@ldez ldez added this to the v1.53 milestone Mar 6, 2024
@alexandear alexandear mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
topic: cosmetic changes contain cosmetic improvements
Projects
None yet
Milestone
v1.53
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandear @ldez