Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gocritic: set Go version in configuration #3807

Closed
wants to merge 1 commit into from
Closed

gocritic: set Go version in configuration #3807

wants to merge 1 commit into from

Conversation

alexandear
Copy link
Member

@alexandear alexandear commented Apr 27, 2023 •
edited
Loading

This PR adds support for Go-language for gocritic linter.

$ gocritic check -h

...
-go string
        select the Go version to target. Leave as string for the latest

@ldez
Copy link
Member

ldez commented Apr 27, 2023 •
edited
Loading

Usually, we wait for the dependabot PR

@ldez ldez closed this Apr 27, 2023
@ldez ldez added the declined label Apr 27, 2023
@alexandear
Copy link
Member Author

dependabot is unwilling to do the PR's changes. It can't add a new Go field to GoCriticSettings, update gocritic's code, and tests. That's why I created this PR.

@ldez
Copy link
Member

ldez commented Apr 27, 2023

Dependabot is not able but we are able to change the PR of the dependabot.
It's how we apply changes related to the update of a linter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
declined
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandear @ldez