gosec: convert global settings as map with proper key type #3779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thank you for opening your first Pull Request ! |
|
|
alexandear
reviewed
Apr 15, 2023
alexandear
reviewed
Apr 15, 2023
alexandear
reviewed
Apr 15, 2023
ldez
added
the
linter: update
Co-authored-by: Oleksandr Redko <[email protected]>
Co-authored-by: Oleksandr Redko <[email protected]>
|
@alexandear could you take a look? Thank you! |
|
@alexandear / @ldez would you like to review this PR? I am waiting for this fix to enable golangci-lint in our project... |
|
LGTM. But I haven't permission to merge. |
|
@alexandear you have to read better:
You are in the team so you can approve (instead of just putting a comment). |
ldez
changed the title
|
hi, thanks for merging this PR. @ldez when will we have a new release? |
bcho
added a commit
to bcho/golangci-lint
that referenced
this pull request
Apr 28, 2023
…3779) Co-authored-by: Fernandez Ludovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3778
gosec's global settings is using following type:
In current implementation, the gosec global settings from golangci-lint's linters-settings will not be converted to the correct type as above.
To fix this issue, this pull request refactored the
*config.GoSecSettingtogosec.Configimplementation to be global option aware.