lll: Advertise max line length instead of just reporting failure (#4781)

Co-authored-by: Fernandez Ludovic <[email protected]>
golangci · Jun 9, 2024 · eb23eaf · eb23eaf
1 parent 78f350b
commit eb23eaf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pkg/golinters/lll/lll.go b/pkg/golinters/lll/lll.go
@@ -121,7 +121,7 @@ func getLLLIssuesForFile(filename string, maxLineLen int, tabSpaces string) ([]r
  Filename: filename,
  Line: lineNumber,
  },
- Text: fmt.Sprintf("line is %d characters", lineLen),
+ Text: fmt.Sprintf("the line is %d characters long, which exceeds the maximum of %d characters.", lineLen, maxLineLen),
  FromLinter: linterName,
  })
  }

diff --git a/test/run_test.go b/test/run_test.go
@@ -218,7 +218,7 @@ func TestLineDirective(t *testing.T) {
  },
  configPath: "testdata/linedirective/lll.yml",
  targetPath: "linedirective",
- expected: "line is 57 characters (lll)",
+ expected: "the line is 57 characters long, which exceeds the maximum of 50 characters. (lll)",
  },
  {
  desc: "misspell",