fixup! fix: Remove unrelated flags from config and linters command

Signed-off-by: Mateus Oliveira <[email protected]>

.golangci.reference.yml

@@ -2649,7 +2649,7 @@ linters:
     - test
     - unused
 
-  # Run only fast linters from enabled linters set (first run won't be fast)
+  # Enable only fast linters from enabled linters set (first run won't be fast)
   # Default: false
   fast: true
 

pkg/commands/linters.go

@@ -20,6 +20,7 @@ func (e *Executor) initLinters() {
 	fs := e.lintersCmd.Flags()
 	fs.SortFlags = false // sort them as they are defined here
 	e.initConfigFileFlagSet(fs, &e.cfg.Run)
+	e.initLintersFlagSet(fs, &e.cfg.Linters)
 	e.rootCmd.AddCommand(e.lintersCmd)
 }
 

pkg/commands/run.go

@@ -68,6 +68,17 @@ func (e *Executor) initConfigFileFlagSet(fs *pflag.FlagSet, cfg *config.Run) {
 	fs.BoolVar(&cfg.NoConfig, "no-config", false, wh("Don't read config file"))
 }
 
+func (e *Executor) initLintersFlagSet(fs *pflag.FlagSet, cfg *config.Linters) {
+	fs.StringSliceVarP(&cfg.Disable, "disable", "D", nil, wh("Disable specific linter"))
+	fs.BoolVar(&cfg.DisableAll, "disable-all", false, wh("Disable all linters"))
+	fs.StringSliceVarP(&cfg.Enable, "enable", "E", nil, wh("Enable specific linter"))
+	fs.BoolVar(&cfg.EnableAll, "enable-all", false, wh("Enable all linters"))
+	fs.BoolVar(&cfg.Fast, "fast", false, wh("Enable only fast linters from enabled linters set (first run won't be fast)"))
+	fs.StringSliceVarP(&cfg.Presets, "presets", "p", nil,
+		wh(fmt.Sprintf("Enable presets (%s) of linters. Run 'golangci-lint help linters' to see "+
+			"them. This option implies option --disable-all", strings.Join(e.DBManager.AllPresets(), "|"))))
+}
+
 //nolint:funlen,gomnd
 func (e *Executor) initFlagSet(fs *pflag.FlagSet, cfg *config.Config, isFinalInit bool) {
 	hideFlag := func(name string) {
@@ -206,15 +217,7 @@ func (e *Executor) initFlagSet(fs *pflag.FlagSet, cfg *config.Config, isFinalIni
 
 	// Linters config
 	lc := &cfg.Linters
-	fs.StringSliceVarP(&lc.Enable, "enable", "E", nil, wh("Enable specific linter"))
-	fs.StringSliceVarP(&lc.Disable, "disable", "D", nil, wh("Disable specific linter"))
-	fs.BoolVar(&lc.EnableAll, "enable-all", false, wh("Enable all linters"))
-
-	fs.BoolVar(&lc.DisableAll, "disable-all", false, wh("Disable all linters"))
-	fs.StringSliceVarP(&lc.Presets, "presets", "p", nil,
-		wh(fmt.Sprintf("Enable presets (%s) of linters. Run 'golangci-lint help linters' to see "+
-			"them. This option implies option --disable-all", strings.Join(e.DBManager.AllPresets(), "|"))))
-	fs.BoolVar(&lc.Fast, "fast", false, wh("Run only fast linters from enabled linters set (first run won't be fast)"))
+	e.initLintersFlagSet(fs, lc)
 
 	// Issues config
 	ic := &cfg.Issues

test/testshared/runner.go

@@ -163,12 +163,13 @@ func (b *RunnerBuilder) Runner() *Runner {
 		b.tb.Fatal("--no-config and -c cannot be used at the same time")
 	}
 
-	arguments := []string{
-		"--internal-cmd-test",
-	}
+	arguments := []string{}
 
-	if b.allowParallelRunners {
-		arguments = append(arguments, "--allow-parallel-runners")
+	if b.command == "run" {
+		arguments = append(arguments, "--internal-cmd-test")
+		if b.allowParallelRunners {
+			arguments = append(arguments, "--allow-parallel-runners")
+		}
 	}
 
 	if b.noConfig {

test/testshared/runner_test.go

@@ -28,11 +28,20 @@ func TestRunnerBuilder_Runner(t *testing.T) {
 			},
 		},
 		{
-			desc:    "with command",
+			desc:    "with non run command",
 			builder: NewRunnerBuilder(t).WithCommand("example"),
 			expected: &Runner{
 				env:     []string(nil),
 				command: "example",
+				args:    []string{},
+			},
+		},
+		{
+			desc:    "with run command",
+			builder: NewRunnerBuilder(t).WithCommand("run"),
+			expected: &Runner{
+				env:     []string(nil),
+				command: "run",
 				args: []string{
 					"--internal-cmd-test",
 					"--allow-parallel-runners",