feat: disable copyloopvar and intrange on Go 1.22

golangci · Feb 17, 2024 · 745a98a · 745a98a
1 parent f4e33e0
commit 745a98a
Show file tree

Hide file tree

Showing 6 changed files with 28 additions and 17 deletions.
diff --git a/pkg/config/config.go b/pkg/config/config.go
@@ -41,18 +41,18 @@ type Version struct {
 	Debug  bool   `mapstructure:"debug"`
 }
 
-func IsGreaterThanOrEqualGo122(v string) bool {
-	v1, err := hcversion.NewVersion(strings.TrimPrefix(v, "go"))
+func IsGoGreaterThanOrEqual(current, limit string) bool {
+	v1, err := hcversion.NewVersion(strings.TrimPrefix(current, "go"))
 	if err != nil {
 		return false
 	}
 
-	limit, err := hcversion.NewVersion("1.22")
+	l, err := hcversion.NewVersion(limit)
 	if err != nil {
 		return false
 	}
 
-	return v1.GreaterThanOrEqual(limit)
+	return v1.GreaterThanOrEqual(l)
 }
 
 func DetectGoVersion() string {

diff --git a/pkg/golinters/govet.go b/pkg/golinters/govet.go
@@ -173,7 +173,7 @@ func analyzersFromConfig(settings *config.GovetSettings) []*analysis.Analyzer {
 
 func isAnalyzerEnabled(name string, cfg *config.GovetSettings, defaultAnalyzers []*analysis.Analyzer) bool {
 	// TODO(ldez) remove loopclosure when go1.23
-	if name == loopclosure.Analyzer.Name && config.IsGreaterThanOrEqualGo122(cfg.Go) {
+	if name == loopclosure.Analyzer.Name && config.IsGoGreaterThanOrEqual(cfg.Go, "1.22") {
 		return false
 	}
 

diff --git a/pkg/golinters/paralleltest.go b/pkg/golinters/paralleltest.go
@@ -18,7 +18,7 @@ func NewParallelTest(settings *config.ParallelTestSettings) *goanalysis.Linter {
 			"ignoremissingsubtests": settings.IgnoreMissingSubtests,
 		}
 
-		if config.IsGreaterThanOrEqualGo122(settings.Go) {
+		if config.IsGoGreaterThanOrEqual(settings.Go, "1.22") {
 			d["ignoreloopVar"] = true
 		}
 

diff --git a/pkg/lint/linter/config.go b/pkg/lint/linter/config.go
@@ -133,11 +133,12 @@ func (lc *Config) Name() string {
 	return lc.Linter.Name()
 }
 
-func (lc *Config) WithNoopFallback(cfg *config.Config) *Config {
-	if cfg != nil && config.IsGreaterThanOrEqualGo122(cfg.Run.Go) {
+func (lc *Config) WithNoopFallback(cfg *config.Config, cond func(cfg *config.Config) bool) *Config {
+	if cfg != nil && cond(cfg) {
 		lc.Linter = &Noop{
-			name: lc.Linter.Name(),
-			desc: lc.Linter.Desc(),
+			name:   lc.Linter.Name(),
+			desc:   lc.Linter.Desc(),
+			reason: "This linter is disabled because the Go version of your project is lower than Go 1.22.",
 			run: func(_ *analysis.Pass) (any, error) {
 				return nil, nil
 			},
@@ -150,6 +151,12 @@ func (lc *Config) WithNoopFallback(cfg *config.Config) *Config {
 	return lc
 }
 
+func IsGoLowerThan(limit string) func(cfg *config.Config) bool {
+	return func(cfg *config.Config) bool {
+		return cfg != nil && !config.IsGoGreaterThanOrEqual(cfg.Run.Go, limit)
+	}
+}
+
 func NewConfig(linter Linter) *Config {
 	lc := &Config{
 		Linter: linter,

diff --git a/pkg/lint/linter/linter.go b/pkg/lint/linter/linter.go
@@ -15,14 +15,16 @@ type Linter interface {
 }
 
 type Noop struct {
-	name string
-	desc string
-	run  func(pass *analysis.Pass) (any, error)
+	name   string
+	desc   string
+	reason string
+	run    func(pass *analysis.Pass) (any, error)
 }
 
 func (n Noop) Run(_ context.Context, lintCtx *Context) ([]result.Issue, error) {
-	lintCtx.Log.Warnf("%s is disabled because of generics."+
-		" You can track the evolution of the generics support by following the https://github.com/golangci/golangci-lint/issues/2649.", n.name)
+	if n.reason != "" {
+		lintCtx.Log.Warnf("%s: %s", n.name, n.reason)
+	}
 	return nil, nil
 }
 

diff --git a/pkg/lint/lintersdb/manager.go b/pkg/lint/lintersdb/manager.go
@@ -303,7 +303,8 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 		linter.NewConfig(golinters.NewCopyLoopVar()).
 			WithSince("v1.57.0").
 			WithPresets(linter.PresetStyle).
-			WithURL("https://github.com/karamaru-alpha/copyloopvar"),
+			WithURL("https://github.com/karamaru-alpha/copyloopvar").
+			WithNoopFallback(m.cfg, linter.IsGoLowerThan("1.22")),
 
 		linter.NewConfig(golinters.NewCyclop(cyclopCfg)).
 			WithSince("v1.37.0").
@@ -617,7 +618,8 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 
 		linter.NewConfig(golinters.NewIntrange()).
 			WithSince("v1.57.0").
-			WithURL("https://github.com/ckaznocha/intrange"),
+			WithURL("https://github.com/ckaznocha/intrange").
+			WithNoopFallback(m.cfg, linter.IsGoLowerThan("1.22")),
 
 		linter.NewConfig(golinters.NewIreturn(ireturnCfg)).
 			WithSince("v1.43.0").