internal/colltab: improve numeric sorting #50
+72
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid using Elem.Primary() == 0 in numeric.go as it has odd ordering
properties, starting at 1 allows 0 to consistently be ordered before
other numbers when non-numeric text follows a 0
Also fixes an issue comparing numbers > 269 characters with
numbers < 270 characters
Sort numbers with leading zeros, as it makes numeric sorting
deterministic. Particularly useful for approximating how an OS file
manager will sort files.
Fixes golang/go#25554