-
Notifications
You must be signed in to change notification settings - Fork 17.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/link: Add missing platform for Mac Catalyst #67176
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This PR (HEAD: b49d36d) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/583295. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/583295. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/583295. |
Message from Cherry Mui: Patch Set 1: Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/583295. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-06T18:39:58Z","revision":"17e7800a3b684b7988a72637d196fec28704c25d"} Please don’t reply on this GitHub thread. Visit golang.org/cl/583295. |
Message from Cherry Mui: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/583295. |
Message from Go LUCI: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/583295. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/583295. |
This PR (HEAD: feae982) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/583295. Important tips:
|
Message from Charles-Philippe Lepage: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/583295. |
Message from Cherry Mui: Patch Set 3: Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/583295. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-07T16:39:40Z","revision":"2b16cc29df76b738f7b8945fc335ae0ad10c2036"} Please don’t reply on this GitHub thread. Visit golang.org/cl/583295. |
Message from Cherry Mui: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/583295. |
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/583295. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/583295. |
Message from David Chase: Patch Set 3: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/583295. |
Fixes #67175 Defines a MachoPlatorm constant in OS_Darwin for MacCatalyst build. This enables adding the suffix $INODE64 on syscall methods needed for amd64 Darwin platform. Change-Id: Ie677e241599e2a14359c5809fa9ddb3b63161629 GitHub-Last-Rev: feae982 GitHub-Pull-Request: #67176 Reviewed-on: https://go-review.googlesource.com/c/go/+/583295 Reviewed-by: Cherry Mui <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: David Chase <[email protected]>
This PR is being closed because golang.org/cl/583295 has been merged. |
Fixes #67175
Defines a MachoPlatorm constant in OS_Darwin for MacCatalyst build. This enables adding the suffix $INODE64 on syscall methods needed for amd64 Darwin platform.