Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 bug: fix EnableSplittingOnParsers is not functional #3231
base: main
Are you sure you want to change the base?
🐛 bug: fix EnableSplittingOnParsers is not functional #3231
Changes from 7 commits
725855d
2260663
a56943d
8ce1fb4
043dd20
d2d2ab7
6dea77f
e2e93a4
47a8f32
e89943b
182d53a
7d50265
2ac8bbf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use Request() method for type safety.
For consistency and type safety, use the abstracted
Request()
method instead of directly accessingRequestCtx().Request
.Apply this change to all affected methods:
Also applies to: 144-144, 218-218
Check warning on line 229 in bind.go
Codecov / codecov/patch
bind.go#L224-L229
Check warning on line 231 in bind.go
Codecov / codecov/patch
bind.go#L231